test: autofix vitest/prefer-strict-boolean-matchers

Author: matejchalk

e2e/ci-e2e/tests/basic.e2e.test.ts

@@ -60,7 +60,7 @@ describe('CI - standalone mode', () => {
         path.join(repo.baseDir, '.code-pushup/.ci/.current/report.json'),
         'utf8',
       );
-      await expect(jsonPromise).resolves.toBeTruthy();
+      await expect(jsonPromise).resolves.toBe(true);
       const report = JSON.parse(await jsonPromise) as Report;
       expect(report).toEqual(
         expect.objectContaining({
@@ -137,7 +137,7 @@ describe('CI - standalone mode', () => {
         path.join(repo.baseDir, '.code-pushup/.ci/.comparison/report-diff.md'),
         'utf8',
       );
-      await expect(mdPromise).resolves.toBeTruthy();
+      await expect(mdPromise).resolves.toBe(true);
       const md = await mdPromise;
       await expect(
         md.replace(/[\da-f]{40}/g, '`<commit-sha>`'),

e2e/ci-e2e/tests/npm-workspaces.e2e.test.ts

@@ -175,7 +175,7 @@ describe('CI - monorepo mode (npm workspaces)', () => {
         path.join(repo.baseDir, '.code-pushup/.ci/.comparison/report-diff.md'),
         'utf8',
       );
-      await expect(mdPromise).resolves.toBeTruthy();
+      await expect(mdPromise).resolves.toBe(true);
       const md = await mdPromise;
       await expect(
         md.replace(/[\da-f]{40}/g, '`<commit-sha>`'),

e2e/ci-e2e/tests/nx-monorepo.e2e.test.ts

@@ -208,7 +208,7 @@ describe('CI - monorepo mode (Nx)', () => {
         path.join(repo.baseDir, '.code-pushup/.ci/.comparison/report-diff.md'),
         'utf8',
       );
-      await expect(mdPromise).resolves.toBeTruthy();
+      await expect(mdPromise).resolves.toBe(true);
       const md = await mdPromise;
       await expect(
         md.replace(/[\da-f]{40}/g, '`<commit-sha>`'),

packages/cli/src/lib/implementation/core-config.middleware.integration.test.ts

@@ -54,7 +54,7 @@ describe('coreConfigMiddleware', () => {
         tsconfig: path.join(configDirPath, 'tsconfig.json'),
         ...CLI_DEFAULTS,
       }),
-    ).resolves.toBeTruthy();
+    ).resolves.toBe(true);
   });
 
   it('should throw if --tsconfig is missing but needed to resolve import', async () => {

packages/core/src/lib/compare.unit.test.ts

@@ -47,7 +47,7 @@ describe('compareReportFiles', () => {
     const reportsDiffPromise = readJsonFile(
       path.join(MEMFS_VOLUME, 'report-diff.json'),
     );
-    await expect(reportsDiffPromise).resolves.toBeTruthy();
+    await expect(reportsDiffPromise).resolves.toBe(true);
 
     const reportsDiff = await reportsDiffPromise;
     expect(() => reportsDiffSchema.parse(reportsDiff)).not.toThrow();
@@ -65,10 +65,10 @@ describe('compareReportFiles', () => {
 
     await expect(
       fileExists(path.join(MEMFS_VOLUME, 'report-diff.json')),
-    ).resolves.toBeTruthy();
+    ).resolves.toBe(true);
     await expect(
       fileExists(path.join(MEMFS_VOLUME, 'report-diff.md')),
-    ).resolves.toBeTruthy();
+    ).resolves.toBe(true);
   });
 
   it('should include portal link (fetched using upload config) in Markdown file', async () => {

packages/plugin-lighthouse/src/lib/utils.unit.test.ts

@@ -57,7 +57,7 @@ describe('validateAudits', () => {
         ],
         ['a'],
       ),
-    ).toBeTruthy();
+    ).toBe(true);
   });
 
   it('should throw if given audits do not exist', () => {
@@ -92,7 +92,7 @@ describe('validateOnlyCategories', () => {
         ],
         'coverage',
       ),
-    ).toBeTruthy();
+    ).toBe(true);
   });
 
   it('should throw if given onlyCategories do not exist', () => {

packages/utils/src/lib/file-system.unit.test.ts

@@ -22,9 +22,9 @@ describe('ensureDirectoryExists', () => {
     const dir = path.join(MEMFS_VOLUME, 'sub', 'dir');
 
     await ensureDirectoryExists(dir);
-    await expect(
-      stat(dir).then(stats => stats.isDirectory()),
-    ).resolves.toBeTruthy();
+    await expect(stat(dir).then(stats => stats.isDirectory())).resolves.toBe(
+      true,
+    );
   });
 });
 

packages/utils/src/lib/semver.unit.test.ts

@@ -19,7 +19,7 @@ describe('isSemver', () => {
     ['1.2.3-alpha-4'],
     ['11.22.33+alpha.4'],
   ])('should return true for a valid semver string: %s', versionString => {
-    expect(isSemver(versionString)).toBeTruthy();
+    expect(isSemver(versionString)).toBe(true);
   });
 
   it.each([
@@ -28,7 +28,7 @@ describe('isSemver', () => {
     ['package-1.2.3-alpha.0'], // (wrong as no @ for prefix)
     ['package-11.22.33-alpha.0'], //(wrong package separator)
   ])('should return false for a invalid semver string: s%', versionString => {
-    expect(isSemver(versionString)).toBeFalsy();
+    expect(isSemver(versionString)).toBe(false);
   });
 });
 

testing/test-setup/src/vitest.d.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions */
 import type { CustomMarkdownTableMatchers } from './lib/extend/markdown-table.matcher.js';
 import type {
   CustomAsymmetricPathMatchers,
@@ -11,7 +10,6 @@ declare module 'vitest' {
     extends CustomPathMatchers,
       CustomUiLoggerMatchers,
       CustomMarkdownTableMatchers {}
-  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
+
   interface AsymmetricMatchersContaining extends CustomAsymmetricPathMatchers {}
 }
-/* eslint-enable @typescript-eslint/consistent-type-definitions */

testing/test-utils/src/lib/utils/file-system.unit.test.ts

@@ -39,9 +39,9 @@ describe('ensureDirectoryExists', () => {
     const dir = path.join(MEMFS_VOLUME, 'sub', 'dir');
 
     await ensureDirectoryExists(dir);
-    await expect(
-      stat(dir).then(stats => stats.isDirectory()),
-    ).resolves.toBeTruthy();
+    await expect(stat(dir).then(stats => stats.isDirectory())).resolves.toBe(
+      true,
+    );
   });
 
   it('should pass if folder exists', async () => {
@@ -55,8 +55,8 @@ describe('ensureDirectoryExists', () => {
     const dir = path.join(MEMFS_VOLUME, 'sub');
 
     await ensureDirectoryExists(dir);
-    await expect(
-      stat(dir).then(stats => stats.isDirectory()),
-    ).resolves.toBeTruthy();
+    await expect(stat(dir).then(stats => stats.isDirectory())).resolves.toBe(
+      true,
+    );
   });
 });