Skip to content

Commit 55c022b

Browse files
author
John Doe
committed
refactor: remove bin option from config
1 parent 06f0b65 commit 55c022b

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

nx.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,14 @@
348348
},
349349
"plugins": [
350350
{
351-
"plugin": "@code-pushup/nx-plugin"
351+
"plugin": "@code-pushup/nx-plugin",
352+
"options": {
353+
"bin": "packages/cli/src/index.ts",
354+
"env": {
355+
"NODE_OPTIONS": "--import tsx",
356+
"TSX_TSCONFIG_PATH": "tsconfig.base.json"
357+
}
358+
}
352359
},
353360
{
354361
"plugin": "@push-based/nx-verdaccio",

packages/nx-plugin/src/executors/internal/cli.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { logger } from '@nx/devkit';
2-
31
export function createCliCommandString(options?: {
42
args?: Record<string, unknown>;
53
command?: string;

packages/nx-plugin/src/generators/configuration/generator.int.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {
77
import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
88
import * as path from 'node:path';
99
import { afterEach, describe, expect, it, vi } from 'vitest';
10-
import { DEFAULT_TARGET_NAME, PACKAGE_NAME } from '../../internal/constants.js';
1110
import { configurationGenerator } from './generator.js';
1211

1312
describe('configurationGenerator', () => {

packages/nx-plugin/src/generators/configuration/schema.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import type { DynamicTargetOptions } from '../../internal/types.js';
22

33
export type ConfigurationGeneratorOptions = {
44
project: string;
5-
bin?: string;
65
skipTarget?: boolean;
76
skipConfig?: boolean;
87
skipFormat?: boolean;

packages/nx-plugin/src/plugin/target/configuration-target.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ export function createConfigurationTarget(options?: {
77
projectName?: string;
88
bin?: string;
99
}): TargetConfiguration<RunCommandsOptions> {
10-
const { projectName, bin = PACKAGE_NAME } = options ?? {};
10+
const { projectName } = options ?? {};
1111
const args = objectToCliArgs({
1212
...(projectName ? { project: projectName } : {}),
1313
});
1414
return {
15-
command: `nx g ${bin}:configuration${args.length > 0 ? ` ${args.join(' ')}` : ''}`,
15+
command: `nx g ${PACKAGE_NAME}:configuration${args.length > 0 ? ` ${args.join(' ')}` : ''}`,
1616
};
1717
}

0 commit comments

Comments
 (0)