refactor: disable no-magic-numbers (rule moved to typescript-eslint)

Author: matejchalk

eslint.config.js

@@ -23,8 +23,8 @@ export default tseslint.config(
         {
           enforceBuildableLibDependency: true,
           allow: [
-            '^.*/eslint(\\.base)?\\.config\\.[cm]?js$',
-            '^.*/code-pushup\\.(config|preset)(\\.m?[jt]s)?$',
+            String.raw`^.*/eslint(\.base)?\.config\.[cm]?js$`,
+            String.raw`^.*/code-pushup\.(config|preset)(\.m?[jt]s)?$`,
             '^[./]+/tools/.*$',
           ],
           depConstraints: [
@@ -87,7 +87,7 @@ export default tseslint.config(
     rules: {
       'vitest/consistent-test-filename': [
         'warn',
-        { pattern: '.*\\.(unit|integration|e2e)\\.test\\.[tj]sx?$' },
+        { pattern: String.raw`.*\.(unit|integration|e2e)\.test\.[tj]sx?$` },
       ],
     },
   },
@@ -98,7 +98,7 @@ export default tseslint.config(
   {
     files: ['**/perf/**/*.ts'],
     rules: {
-      'no-magic-numbers': 'off',
+      '@typescript-eslint/no-magic-numbers': 'off',
       'sonarjs/no-duplicate-string': 'off',
     },
   },

examples/plugins/src/lighthouse/src/constants.ts

@@ -76,6 +76,7 @@ export const categoryCorePerfGroup: Group = {
   slug: LIGHTHOUSE_PERFORMANCE_CORE_GROUP_SLUG,
   title: 'performance-core',
   refs: [
+    /* eslint-disable @typescript-eslint/no-magic-numbers */
     // web vitals
     {
       slug: fcpSlug,
@@ -110,6 +111,7 @@ export const categoryCorePerfGroup: Group = {
       slug: 'user-timings',
       weight: 0,
     },
+    /* eslint-enable @typescript-eslint/no-magic-numbers */
   ],
 };
 
@@ -118,6 +120,7 @@ export const categoryCorePerfGroup2: Group = {
   title: 'performance-core-2',
   refs: [
     // web vitals
+    /* eslint-disable @typescript-eslint/no-magic-numbers */
     {
       slug: 'first-contentful-paint',
       weight: 10,
@@ -138,5 +141,6 @@ export const categoryCorePerfGroup2: Group = {
       slug: 'speed-index',
       weight: 10,
     },
+    /* eslint-enable @typescript-eslint/no-magic-numbers */
   ],
 };

packages/cli/src/lib/history/history.options.ts

@@ -30,7 +30,7 @@ export function yargsHistoryOptionsDefinition(): Record<
       // https://git-scm.com/docs/git-log#Documentation/git-log.txt---max-countltnumbergt
       describe: 'Number of steps in history',
       type: 'number',
-
+      // eslint-disable-next-line @typescript-eslint/no-magic-numbers
       default: 5,
     },
     from: {

packages/plugin-coverage/src/lib/utils.ts

@@ -24,7 +24,9 @@ export function applyMaxScoreAboveThreshold(
 }
 
 export const coverageTypeWeightMapper: Record<CoverageType, number> = {
+  /* eslint-disable @typescript-eslint/no-magic-numbers */
   function: 6,
   branch: 3,
   line: 1,
+  /* eslint-enable @typescript-eslint/no-magic-numbers */
 };

packages/plugin-js-packages/src/lib/constants.ts

@@ -23,9 +23,11 @@ export const dependencyGroupToLong: Record<
 };
 
 export const dependencyGroupWeights: Record<DependencyGroup, number> = {
+  /* eslint-disable @typescript-eslint/no-magic-numbers */
   prod: 80,
   dev: 15,
   optional: 5,
+  /* eslint-enable @typescript-eslint/no-magic-numbers */
 };
 
 export const dependencyDocs: Record<DependencyGroup, string> = {

packages/plugin-js-packages/src/lib/runner/audit/constants.ts

@@ -1,9 +1,11 @@
 import type { PackageAuditLevel } from '../../config.js';
 
 export const auditScoreModifiers: Record<PackageAuditLevel, number> = {
+  /* eslint-disable @typescript-eslint/no-magic-numbers */
   critical: 1,
   high: 0.1,
   moderate: 0.05,
   low: 0.02,
   info: 0.01,
+  /* eslint-enable @typescript-eslint/no-magic-numbers */
 };

packages/plugin-lighthouse/src/lib/runner/details/item-value.ts

@@ -58,6 +58,7 @@ export function formatTableItemPropertyValue(
 
   const parsedItemValue = parseTableItemPropertyValue(itemValue);
 
+  /* eslint-disable @typescript-eslint/no-magic-numbers */
   switch (itemValueFormat) {
     case 'bytes':
       return formatBytes(Number(parsedItemValue));
@@ -93,6 +94,7 @@ export function formatTableItemPropertyValue(
       ui().logger.info(`Format type ${bold('thumbnail')} is not implemented`);
       return '';
   }
+  /* eslint-enable @typescript-eslint/no-magic-numbers */
 
   return itemValue;
 }

packages/utils/src/lib/reports/constants.ts

@@ -2,8 +2,10 @@
 export const TERMINAL_WIDTH = 80;
 
 export const SCORE_COLOR_RANGE = {
+  /* eslint-disable @typescript-eslint/no-magic-numbers */
   GREEN_MIN: 0.9,
   YELLOW_MIN: 0.5,
+  /* eslint-enable @typescript-eslint/no-magic-numbers */
 };
 
 export const FOOTER_PREFIX = 'Made with ❤ by'; // replace ❤️ with ❤, because ❤️ has output issues in terminal

packages/utils/src/lib/reports/log-stdout-summary.ts

@@ -81,12 +81,14 @@ function logRow(score: number, title: string, value?: string): void {
     },
     {
       text: title,
+      // eslint-disable-next-line @typescript-eslint/no-magic-numbers
       padding: [0, 3, 0, 0],
     },
     ...(value
       ? [
           {
             text: cyanBright(value),
+            // eslint-disable-next-line @typescript-eslint/no-magic-numbers
             width: 20,
             padding: [0, 0, 0, 0],
           },
@@ -107,6 +109,7 @@ export function logCategories({
     countCategoryAudits(refs, plugins),
   ]);
   const table = ui().table();
+  // eslint-disable-next-line @typescript-eslint/no-magic-numbers
   table.columnWidths([TERMINAL_WIDTH - 9 - 10 - 4, 9, 10]);
   table.head(
     REPORT_RAW_OVERVIEW_TABLE_HEADERS.map((heading, idx) => ({

packages/utils/src/lib/text-formats/constants.ts

@@ -3,10 +3,12 @@ export const TAB = '  ';
 export const SPACE = ' ';
 
 export const HIERARCHY = {
+  /* eslint-disable @typescript-eslint/no-magic-numbers */
   level_1: 1,
   level_2: 2,
   level_3: 3,
   level_4: 4,
   level_5: 5,
   level_6: 6,
+  /* eslint-enable @typescript-eslint/no-magic-numbers */
 } as const;