Skip to content

Commit 3541c80

Browse files
author
John Doe
committed
chore: refine preset 2
1 parent 55bc628 commit 3541c80

File tree

1 file changed

+15
-14
lines changed

1 file changed

+15
-14
lines changed

code-pushup.preset.ts

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ import eslintPlugin, {
1111
eslintConfigFromNxProject,
1212
} from './packages/plugin-eslint/src/index.js';
1313
import jsPackagesPlugin from './packages/plugin-js-packages/src/index.js';
14-
import jsDocsPlugin, {
15-
JsDocsPluginConfig,
16-
} from './packages/plugin-jsdocs/src/index.js';
14+
import jsDocsPlugin from './packages/plugin-jsdocs/src/index.js';
15+
import type { JsDocsPluginTransformedConfig } from './packages/plugin-jsdocs/src/lib/config.js';
1716
import {
1817
PLUGIN_SLUG,
1918
groups,
@@ -98,7 +97,7 @@ export const eslintCategories: CategoryConfig[] = [
9897
];
9998

10099
export function getJsDocsCategories(
101-
config: JsDocsPluginConfig,
100+
config: JsDocsPluginTransformedConfig,
102101
): CategoryConfig[] {
103102
return [
104103
{
@@ -147,7 +146,7 @@ export const lighthouseCoreConfig = async (
147146
};
148147

149148
export const jsDocsCoreConfig = (
150-
config: JsDocsPluginConfig | string[],
149+
config: JsDocsPluginTransformedConfig | string[],
151150
): CoreConfig => ({
152151
plugins: [
153152
jsDocsPlugin(Array.isArray(config) ? { patterns: config } : config),
@@ -180,9 +179,6 @@ export const typescriptPluginConfig = async (
180179
export const coverageCoreConfigNx = async (
181180
projectName?: string,
182181
): Promise<CoreConfig> => {
183-
if (projectName) {
184-
throw new Error('coverageCoreConfigNx for single projects not implemented');
185-
}
186182
const targetNames = ['unit-test', 'int-test'];
187183
const targetArgs = [
188184
'-t',
@@ -195,13 +191,18 @@ export const coverageCoreConfigNx = async (
195191
await coveragePlugin({
196192
coverageToolCommand: {
197193
command: 'npx',
198-
args: [
199-
'nx',
200-
projectName ? `run --project ${projectName}` : 'run-many',
201-
...targetArgs,
202-
],
194+
args: projectName
195+
? ['nx', 'run-many', '-p', projectName, ...targetArgs]
196+
: ['nx', 'run-many', ...targetArgs],
203197
},
204-
reports: await getNxCoveragePaths(targetNames),
198+
reports: projectName
199+
? [
200+
{
201+
pathToProject: `packages/${projectName}`,
202+
resultsPath: `packages/${projectName}/coverage/lcov.info`,
203+
},
204+
]
205+
: await getNxCoveragePaths(targetNames),
205206
}),
206207
],
207208
categories: coverageCategories,

0 commit comments

Comments
 (0)