feat(nx-plugin): fix tests and mr comments

Author: AS

packages/models/src/index.ts

@@ -133,6 +133,6 @@ export {
 } from './lib/tree.js';
 export { uploadConfigSchema, type UploadConfig } from './lib/upload-config.js';
 export {
-  artifactGenerationCommand as toolCommandSchema,
+  artifactGenerationCommand,
   pluginArtefactOptionsSchema,
 } from './lib/configuration';

packages/models/src/lib/configuration.ts

@@ -4,10 +4,10 @@ import { z } from 'zod';
  * Generic schema for a tool command configuration, reusable across plugins.
  */
 export const artifactGenerationCommand = z.object({
-  command: z.string({ description: 'Command to run the tool.' }).min(1),
+  command: z.string({ description: 'Generate artifact files' }).min(1),
   args: z
     .array(z.string(), {
-      description: 'Arguments to be passed to the tool.',
+      description: 'Arguments to be passed to the artefact generation command.',
     })
     .optional(),
 });

packages/models/src/lib/configuration.unit.test.ts

@@ -7,89 +7,93 @@ import {
 describe('artifactGenerationCommand', () => {
   it('should validate a command with required fields', () => {
     const data = { command: 'npx' };
-    const result = artifactGenerationCommand.safeParse(data);
-    expect(result.success).toBe(true);
-    if (result.success) {
-      expect(result.data.command).toBe('npx');
-      expect(result.data.args).toBeUndefined();
-    }
+    expect(artifactGenerationCommand.safeParse(data)).toStrictEqual({
+      success: true,
+      data: { command: 'npx' },
+    });
   });
 
   it('should validate a command with args', () => {
     const data = { command: 'npx', args: ['eslint', 'src/'] };
-    const result = artifactGenerationCommand.safeParse(data);
-    expect(result.success).toBe(true);
-    if (result.success) {
-      expect(result.data.command).toBe('npx');
-      expect(result.data.args).toEqual(['eslint', 'src/']);
-    }
+    expect(artifactGenerationCommand.safeParse(data)).toStrictEqual({
+      success: true,
+      data: { command: 'npx', args: ['eslint', 'src/'] },
+    });
   });
 
   it('should fail if command is missing', () => {
     const data = { args: ['eslint', 'src/'] };
-    const result = artifactGenerationCommand.safeParse(data);
-    expect(result.success).toBe(false);
+    expect(artifactGenerationCommand.safeParse(data).success).toBe(false);
   });
 
   it('should fail if command is empty', () => {
     const data = { command: '' };
-    const result = artifactGenerationCommand.safeParse(data);
-    expect(result.success).toBe(false);
+    expect(artifactGenerationCommand.safeParse(data).success).toBe(false);
   });
 
   it('should fail if args is not an array of strings', () => {
     const data = { command: 'npx', args: [123, true] };
-    const result = artifactGenerationCommand.safeParse(data);
-    expect(result.success).toBe(false);
+    expect(artifactGenerationCommand.safeParse(data).success).toBe(false);
   });
 });
 
 describe('pluginArtefactOptionsSchema', () => {
   it('should validate with only artefactsPaths as string', () => {
     const data = { artefactsPaths: 'dist/report.json' };
-    const { success } = pluginArtefactOptionsSchema.safeParse(data);
-    expect(success).toBe(true);
+    expect(pluginArtefactOptionsSchema.safeParse(data)).toStrictEqual({
+      success: true,
+      data: {
+        artefactsPaths: 'dist/report.json',
+        generateArtefacts: undefined,
+      },
+    });
   });
 
   it('should validate with artefactsPaths as array of strings', () => {
     const data = { artefactsPaths: ['dist/report.json', 'dist/summary.json'] };
-    const { success } = pluginArtefactOptionsSchema.safeParse(data);
-    expect(success).toBe(true);
+    expect(pluginArtefactOptionsSchema.safeParse(data)).toStrictEqual({
+      success: true,
+      data: {
+        artefactsPaths: ['dist/report.json', 'dist/summary.json'],
+        generateArtefacts: undefined,
+      },
+    });
   });
 
   it('should fail if artefactsPaths is an empty array', () => {
     const data = { artefactsPaths: [] };
-    const { success } = pluginArtefactOptionsSchema.safeParse(data);
-    expect(success).toBe(false);
+    expect(pluginArtefactOptionsSchema.safeParse(data).success).toBe(false);
   });
 
   it('should validate with generateArtefacts and artefactsPaths', () => {
     const data = {
       generateArtefacts: { command: 'npm', args: ['run', 'build'] },
       artefactsPaths: ['dist/report.json'],
     };
-    const { success } = pluginArtefactOptionsSchema.safeParse(data);
-    expect(success).toBe(true);
+    expect(pluginArtefactOptionsSchema.safeParse(data)).toStrictEqual({
+      success: true,
+      data: {
+        generateArtefacts: { command: 'npm', args: ['run', 'build'] },
+        artefactsPaths: ['dist/report.json'],
+      },
+    });
   });
 
   it('should fail if artefactsPaths is missing', () => {
     const data = { generateArtefacts: { command: 'npm' } };
-    const { success } = pluginArtefactOptionsSchema.safeParse(data);
-    expect(success).toBe(false);
+    expect(pluginArtefactOptionsSchema.safeParse(data).success).toBe(false);
   });
 
   it('should fail if artefactsPaths is not string or array of strings', () => {
     const data = { artefactsPaths: 123 };
-    const { success } = pluginArtefactOptionsSchema.safeParse(data);
-    expect(success).toBe(false);
+    expect(pluginArtefactOptionsSchema.safeParse(data).success).toBe(false);
   });
 
   it('should fail if generateArtefacts is invalid', () => {
     const data = {
       generateArtefacts: { command: '' },
       artefactsPaths: 'dist/report.json',
     };
-    const { success } = pluginArtefactOptionsSchema.safeParse(data);
-    expect(success).toBe(false);
+    expect(pluginArtefactOptionsSchema.safeParse(data).success).toBe(false);
   });
 });

packages/plugin-coverage/src/lib/config.ts

@@ -1,5 +1,4 @@
 import { z } from 'zod';
-import { toolCommandSchema } from '@code-pushup/models';
 
 export const coverageTypeSchema = z.enum(['function', 'branch', 'line']);
 export type CoverageType = z.infer<typeof coverageTypeSchema>;