refactor: fix lint

Author: Michael Hladky

packages/plugin-bundle-stats/package.json

@@ -23,13 +23,12 @@
   },
   "type": "module",
   "dependencies": {
-    "@code-pushup/models": "0.69.2",
-    "@code-pushup/utils": "0.69.2",
-    "zod": "^3.23.8"
-  },
-  "peerDependencies": {
-    "typescript": ">=4.0.0"
+    "@code-pushup/models": "0.92.1",
+    "@code-pushup/utils": "0.92.1",
+    "minimatch": "^10.0.1",
+    "vite": "6.3.5"
   },
+  "peerDependencies": {},
   "scripts": {},
   "devDependencies": {
     "@angular/cli": "^20.0.3",

packages/plugin-bundle-stats/project.json

@@ -81,38 +81,10 @@
         }
       }
     },
-    "build": {
-      "executor": "@nx/js:tsc",
-      "outputs": ["{options.outputPath}"],
-      "options": {
-        "outputPath": "dist/packages/plugin-bundle-stats",
-        "main": "packages/plugin-bundle-stats/src/index.ts",
-        "tsConfig": "packages/plugin-bundle-stats/tsconfig.lib.json",
-        "assets": ["packages/plugin-bundle-stats/*.md"]
-      }
-    },
-    "lint": {
-      "executor": "@nx/linter:eslint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": [
-          "packages/plugin-bundle-stats/**/*.ts",
-          "packages/plugin-bundle-stats/package.json"
-        ]
-      }
-    },
-    "unit-test": {
-      "executor": "@nx/vite:test",
-      "options": {
-        "configFile": "packages/plugin-bundle-stats/vite.config.unit.ts"
-      }
-    },
-    "integration-test": {
-      "executor": "@nx/vite:test",
-      "options": {
-        "configFile": "packages/plugin-bundle-stats/vite.config.integration.ts"
-      }
-    }
+    "build": {},
+    "lint": {},
+    "unit-test": {},
+    "int-test": {}
   },
   "tags": ["scope:plugin", "type:feature", "publishable"]
 }

packages/plugin-bundle-stats/src/index.ts

@@ -1,4 +1,4 @@
-import { bundleStatsPlugin } from './lib/bundle-stats-plugin';
+import { bundleStatsPlugin } from './lib/bundle-stats-plugin.js';
 
 export type {
   BundleStatsAuditOptions as BundleStatsOptions,
@@ -7,7 +7,7 @@ export type {
 export type {
   GroupingRule,
   PatternList,
-  BundleStatsConfig as BundleStatsConfig,
+  BundleStatsConfig,
 } from './lib/runner/types.js';
 export type { BlacklistEntry } from './lib/runner/audits/scoring.js';
 

packages/plugin-bundle-stats/src/lib/normalize.ts

@@ -1,9 +1,8 @@
 import type { Audit } from '@code-pushup/models';
-import { slugify } from '@code-pushup/utils';
-import { formatBytes } from '@code-pushup/utils';
+import { formatBytes, slugify } from '@code-pushup/utils';
 import type { BundleStatsConfig as ExportedBundleStatsConfig } from '../index.js';
 import type { InsightsTableConfig } from './runner/audits/details/table.js';
-import { type DependencyTreeConfig } from './runner/audits/details/tree.js';
+import type { DependencyTreeConfig } from './runner/audits/details/tree.js';
 import type { PenaltyConfig, ScoringConfig } from './runner/audits/scoring.js';
 import { DEFAULT_PENALTY } from './runner/audits/scoring.js';
 import type { SelectionConfig } from './runner/audits/selection.js';
@@ -55,8 +54,8 @@ function formatStandardizedIssuesSection(scoring: ScoringConfig): string {
     if (penalty.blacklist && penalty.blacklist.length > 0) {
       items.push(
         `  - Error: \`1+\` candidates - Violation detected, requires action`,
+        `  - Info: \`0\` candidates - No violations found`,
       );
-      items.push(`  - Info: \`0\` candidates - No violations found`);
     } else if (penalty.artefactSize) {
       const [, max] = penalty.artefactSize;
       items.push(
@@ -110,14 +109,18 @@ function formatStandardizedTreeSection(
   let pruningText = 'Default settings';
   if (pruning) {
     const pruningParts: string[] = [];
-    if (pruning.minSize)
+    if (pruning.minSize) {
       pruningParts.push(`Min size: \`${formatBytes(pruning.minSize)}\``);
-    if (pruning.maxChildren)
+    }
+    if (pruning.maxChildren) {
       pruningParts.push(`Max children: \`${pruning.maxChildren}\``);
-    if (pruning.maxDepth)
+    }
+    if (pruning.maxDepth) {
       pruningParts.push(`Max depth: \`${pruning.maxDepth}\``);
-    if (pruning.pathLength)
+    }
+    if (pruning.pathLength) {
       pruningParts.push(`Path length: \`${pruning.pathLength}\``);
+    }
 
     if (pruningParts.length > 0) {
       pruningText = pruningParts.join(', ');
@@ -129,8 +132,12 @@ function formatStandardizedTreeSection(
   if (groups && groups.length > 0) {
     const groupSummaries = groups.map(group => {
       const parts: string[] = [];
-      if (group.title) parts.push(`"${group.title}"`);
-      if (group.icon) parts.push(`${group.icon}`);
+      if (group.title) {
+        parts.push(`"${group.title}"`);
+      }
+      if (group.icon) {
+        parts.push(`${group.icon}`);
+      }
       if (group.includeInputs) {
         if (Array.isArray(group.includeInputs)) {
           const includePatterns = group.includeInputs
@@ -257,24 +264,34 @@ export function prepareDescription(config: BundleStatsConfig): string {
 
     // Add standardized sections
     const scoringSection = formatStandardizedScoringSection(scoring);
-    if (scoringSection) sections.push(scoringSection);
+    if (scoringSection) {
+      sections.push(scoringSection);
+    }
 
     const issuesSection = formatStandardizedIssuesSection(scoring);
-    if (issuesSection) sections.push(issuesSection);
+    if (issuesSection) {
+      sections.push(issuesSection);
+    }
 
     const selectionSection = formatStandardizedSelectionSection(selection);
-    if (selectionSection) sections.push(selectionSection);
+    if (selectionSection) {
+      sections.push(selectionSection);
+    }
 
     // Handle insightsTable which could be false
     const normalizedInsightsTable =
       insightsTable === false ? undefined : insightsTable;
     const tableSection = formatStandardizedTableSection(
       normalizedInsightsTable,
     );
-    if (tableSection) sections.push(tableSection);
+    if (tableSection) {
+      sections.push(tableSection);
+    }
 
     const treeSection = formatStandardizedTreeSection(dependencyTree);
-    if (treeSection) sections.push(treeSection);
+    if (treeSection) {
+      sections.push(treeSection);
+    }
 
     // Wrap config sections in details if any exist
     if (sections.length > 0) {
@@ -342,7 +359,7 @@ export function normalizeBundleStatsOptions(
   // Use the proper selection normalization helper that merges global patterns
   const normalizedSelection = normalizeSelectionOptions(selection);
 
-  let normalizedPenalty: false | PenaltyConfig | undefined = undefined;
+  let normalizedPenalty: false | PenaltyConfig | undefined;
   if (penalty && typeof penalty === 'object') {
     const { artefactSize, ...restPenalty } = penalty;
     normalizedPenalty = {
@@ -413,7 +430,7 @@ export function normalizeDependencyTreeOptions(
       maxChildren: 10,
       minSize: 1000,
       pathLength: 60,
-      ...(options?.pruning ?? {}),
+      ...options?.pruning,
     },
     mode: options?.mode ?? 'onlyMatching',
   };
@@ -451,13 +468,11 @@ export function normalizeRange(range: MinMax | number): MinMax {
 }
 
 export function getAuditsFromConfigs(configs: BundleStatsConfig[]): Audit[] {
-  return configs.map(({ slug, title, description }) => {
-    return {
-      slug,
-      title,
-      description,
-    };
-  });
+  return configs.map(({ slug, title, description }) => ({
+    slug,
+    title,
+    description,
+  }));
 }
 
 /**

packages/plugin-bundle-stats/src/lib/runner/audits/audit-outputs.ts

@@ -1,8 +1,7 @@
 import type { AuditOutput } from '@code-pushup/models';
 import type { BundleStatsConfig } from '../types.js';
 import type { UnifiedStats } from '../unify/unified-stats.types.js';
-import { createDisplayValue } from '../utils.js';
-import { createEmptyAudit } from '../utils.js';
+import { createDisplayValue, createEmptyAudit } from '../utils.js';
 import { createAuditOutputDetails } from './details/audit-details.js';
 import { getIssues } from './details/issues.js';
 import { createBundleStatsScoring } from './scoring.js';

packages/plugin-bundle-stats/src/lib/runner/audits/audit-outputs.unit.test.ts

@@ -51,7 +51,7 @@ describe('generateAuditOutputs', () => {
             },
             scoring: {
               mode: 'onlyMatching',
-              totalSize: [1000, 10000],
+              totalSize: [1000, 10_000],
             },
           },
         ],

packages/plugin-bundle-stats/src/lib/runner/audits/details/formatting.ts

@@ -4,14 +4,16 @@ import {
   findSegmentIndex,
   normalizePathForMatching,
   splitPathSegments,
-} from './grouping';
+} from './grouping.js';
 
 // Regex cache to avoid recreating the same regex patterns
 const REGEX_CACHE = new Map<string, RegExp>();
 
 function getCachedRegex(pattern: string): RegExp {
   const cached = REGEX_CACHE.get(pattern);
-  if (cached) return cached;
+  if (cached) {
+    return cached;
+  }
 
   const regex = new RegExp(`${pattern}\\/([^\\/]+)`);
   REGEX_CACHE.set(pattern, regex);
@@ -42,9 +44,11 @@ export function extractScopedPackage(
 export function extractMeaningfulPathPart(path: string): string | null {
   const parts = splitPathSegments(path.replace(/^\.\//, ''));
 
-  if (parts.length === 0) return null;
+  if (parts.length === 0) {
+    return null;
+  }
 
-  const lastPart = parts[parts.length - 1];
+  const lastPart = parts.at(-1);
   if (lastPart) {
     const withoutExt = removeFileExtension(lastPart);
     if (withoutExt && !isGenericName(withoutExt)) {
@@ -53,7 +57,7 @@ export function extractMeaningfulPathPart(path: string): string | null {
   }
 
   if (parts.length > 1) {
-    const secondLast = parts[parts.length - 2];
+    const secondLast = parts.at(-2);
     if (secondLast && !isGenericName(secondLast)) {
       return secondLast;
     }
@@ -71,12 +75,16 @@ export function cleanupGroupName(groupName: string): string {
   }
 
   const segments = splitPathSegments(groupName);
-  if (segments.length === 0) return groupName;
+  if (segments.length === 0) {
+    return groupName;
+  }
 
   // For scoped packages, try to extract the scope and package
   for (let i = 0; i < segments.length; i++) {
     const segment = segments[i];
-    if (!segment) continue;
+    if (!segment) {
+      continue;
+    }
 
     // Handle scoped packages like @angular/router
     if (segment.startsWith('@') && i + 1 < segments.length) {
@@ -89,7 +97,9 @@ export function cleanupGroupName(groupName: string): string {
   // Extract the last meaningful segment (the actual package/folder name)
   for (let i = segments.length - 1; i >= 0; i--) {
     const segment = segments[i];
-    if (!segment || isGenericName(segment)) continue;
+    if (!segment || isGenericName(segment)) {
+      continue;
+    }
 
     // Return the first meaningful segment we find from the end
     return segment;