refactor: fix e2e

Author: BioPhoton

e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts

@@ -173,12 +173,10 @@ describe('nx-plugin', () => {
     });
 
     const cleanStdout = removeColorCodes(stdout);
-    // @TODO create test environment for working plugin. This here misses package-lock.json to execute correctly
-    expect(cleanStdout).toContain('Executing command:');
-    expect(cleanStdout).toContain('npx @code-pushup/cli');
-    expect(cleanStdout).toContain(
-      'NX   Successfully ran target code-pushup for project my-lib',
-    );
+    expect(cleanStdout).toContain('nx run my-lib:code-pushup');
+    expect(cleanStdout).toContain('$ npx @code-pushup/cli ');
+    expect(cleanStdout).toContain('--dryRun --verbose');
+    expect(cleanStdout).toContain(`--upload.project=\\"${project}\\"`);
   });
 
   it('should consider plugin option cliBin in executor target', async () => {

packages/nx-plugin/src/executors/cli/executor.ts

@@ -9,7 +9,6 @@ import type { AutorunCommandExecutorOptions } from './schema.js';
 import { mergeExecutorOptions, parseAutorunExecutorOptions } from './utils.js';
 
 export function stringifyError(error: unknown): string {
-  // TODO: special handling for ZodError instances
   if (error instanceof Error) {
     if (error.name === 'Error' || error.message.startsWith(error.name)) {
       return error.message;
@@ -58,6 +57,7 @@ export default async function runAutorunExecutor(
       ...(context.cwd ? { cwd: context.cwd } : {}),
       env,
       dryRun,
+      verbose,
     });
   } catch (error) {
     logger.error(error);

packages/nx-plugin/src/internal/command.ts

@@ -1,5 +1,5 @@
 import ansis from 'ansis';
-import path from 'node:path';
+import * as path from 'node:path';
 
 type ArgumentValue = number | string | boolean | string[] | undefined;
 export type CliArgsObject<T extends object = Record<string, ArgumentValue>> =

testing/test-nx-utils/src/lib/utils/nx.ts

@@ -84,7 +84,7 @@ export async function nxShowProjectJson<T extends ProjectConfiguration>(
 ) {
   const { code, stderr, stdout } = await executeProcess({
     command: 'npx',
-    args: ['nx', 'show', `project ${project}  --json`],
+    args: ['nx', 'show', 'project', '--json', project],
     cwd,
   });