fix(plugin-typescript): refine testing types; use ui logger

Author: BioPhoton

packages/plugin-typescript/src/lib/schema.unit.test.ts

@@ -11,15 +11,15 @@ describe('typescriptPluginConfigSchema', () => {
     expect(() => typescriptPluginConfigSchema.parse({})).not.toThrow();
   });
 
-  it('accepts a configuration with tsConfigPath set', () => {
+  it('accepts a configuration with tsconfig set', () => {
     expect(() =>
       typescriptPluginConfigSchema.parse({
         tsconfig,
       } satisfies TypescriptPluginOptions),
     ).not.toThrow();
   });
 
-  it('accepts a configuration with tsConfigPath and empty onlyAudits', () => {
+  it('accepts a configuration with tsconfig and empty onlyAudits', () => {
     expect(() =>
       typescriptPluginConfigSchema.parse({
         tsconfig,
@@ -28,7 +28,7 @@ describe('typescriptPluginConfigSchema', () => {
     ).not.toThrow();
   });
 
-  it('accepts a configuration with tsConfigPath and full onlyAudits', () => {
+  it('accepts a configuration with tsconfig and full onlyAudits', () => {
     expect(() =>
       typescriptPluginConfigSchema.parse({
         tsconfig,

packages/plugin-typescript/src/lib/utils.unit.test.ts

@@ -1,6 +1,7 @@
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
-import { type Audit, categoryRefSchema } from '@code-pushup/models';
-import { AUDITS } from './constants.js';
+import {describe, expect, it} from 'vitest';
+import {type Audit, categoryRefSchema} from '@code-pushup/models';
+import {ui} from '@code-pushup/utils';
+import {AUDITS} from './constants.js';
 import {
   filterAuditsByCompilerOptions,
   filterAuditsBySlug,
@@ -99,31 +100,21 @@ describe('getCategoryRefsFromGroups', () => {
 
   it('should return all groups as categoryRefs if compiler options are given', async () => {
     const categoryRefs = await getCategoryRefsFromGroups({
-      tsConfigPath: 'tsconfig.json',
+      tsconfig: 'tsconfig.json',
     });
     expect(categoryRefs).toHaveLength(3);
   });
 
   it('should return a subset of all groups as categoryRefs if compiler options contain onlyAudits filter', async () => {
     const categoryRefs = await getCategoryRefsFromGroups({
-      tsConfigPath: 'tsconfig.json',
+      tsconfig: 'tsconfig.json',
       onlyAudits: ['semantic-errors'],
     });
     expect(categoryRefs).toHaveLength(1);
   });
 });
 
 describe('logSkippedAudits', () => {
-  beforeEach(() => {
-    vi.mock('console', () => ({
-      warn: vi.fn(),
-    }));
-  });
-
-  afterEach(() => {
-    vi.restoreAllMocks();
-  });
-
   it('should not warn when all audits are included', () => {
     logSkippedAudits(AUDITS);
 
@@ -133,18 +124,15 @@ describe('logSkippedAudits', () => {
   it('should warn about skipped audits', () => {
     logSkippedAudits(AUDITS.slice(0, -1));
 
-    expect(console.warn).toHaveBeenCalledTimes(1);
-    expect(console.warn).toHaveBeenCalledWith(
+    expect(ui()).toHaveLogged(
+      'info',
       expect.stringContaining(`Skipped audits: [`),
     );
   });
 
   it('should camel case the slugs in the audit message', () => {
     logSkippedAudits(AUDITS.slice(0, -1));
 
-    expect(console.warn).toHaveBeenCalledTimes(1);
-    expect(console.warn).toHaveBeenCalledWith(
-      expect.stringContaining(`unknownCodes`),
-    );
+    expect(ui()).toHaveLogged('info', expect.stringContaining(`unknownCodes`));
   });
 });

packages/plugin-typescript/vite.config.unit.ts

@@ -23,6 +23,7 @@ export default defineConfig({
     globalSetup: ['../../global-setup.ts'],
     setupFiles: [
       '../../testing/test-setup/src/lib/cliui.mock.ts',
+      '../../testing/test-setup/src/lib/extend/ui-logger.matcher.ts',
       '../../testing/test-setup/src/lib/fs.mock.ts',
       '../../testing/test-setup/src/lib/console.mock.ts',
       '../../testing/test-setup/src/lib/reset.mocks.ts',