refactor(plugin-js-packages): use runner function instead of runner config

Author: matejchalk

packages/plugin-js-packages/package.json

@@ -41,7 +41,6 @@
     "@code-pushup/utils": "0.96.1",
     "build-md": "^0.4.1",
     "semver": "^7.6.0",
-    "yargs": "^17.7.2",
     "zod": "^4.0.5"
   },
   "files": [

packages/plugin-js-packages/project.json

@@ -7,7 +7,6 @@
     "build": {},
     "lint": {},
     "unit-test": {},
-    "int-test": {},
     "code-pushup": {},
     "code-pushup-eslint": {},
     "code-pushup-coverage": {},

packages/plugin-js-packages/src/bin.ts

@@ -1,6 +1,4 @@
 import { createRequire } from 'node:module';
-import path from 'node:path';
-import { fileURLToPath } from 'node:url';
 import type { Audit, Group, PluginConfig } from '@code-pushup/models';
 import {
   type DependencyGroup,
@@ -11,7 +9,7 @@ import {
 } from './config.js';
 import { dependencyDocs, dependencyGroupWeights } from './constants.js';
 import { packageManagers } from './package-managers/package-managers.js';
-import { createRunnerConfig } from './runner/index.js';
+import { createRunnerFunction } from './runner/index.js';
 import { normalizeConfig } from './utils.js';
 
 /**
@@ -42,12 +40,6 @@ export async function jsPackagesPlugin(
     ...jsPackagesPluginConfigRest
   } = await normalizeConfig(config);
 
-  const runnerScriptPath = path.join(
-    fileURLToPath(path.dirname(import.meta.url)),
-    '..',
-    'bin.js',
-  );
-
   const packageJson = createRequire(import.meta.url)(
     '../../package.json',
   ) as typeof import('../../package.json');
@@ -63,7 +55,7 @@ export async function jsPackagesPlugin(
     version: packageJson.version,
     audits: createAudits(packageManager.slug, checks, depGroups),
     groups: createGroups(packageManager.slug, checks, depGroups),
-    runner: await createRunnerConfig(runnerScriptPath, {
+    runner: createRunnerFunction({
       ...jsPackagesPluginConfigRest,
       checks,
       packageManager: packageManager.slug,

packages/plugin-js-packages/src/lib/js-packages-plugin.ts

@@ -3,19 +3,11 @@ import { describe, expect, it } from 'vitest';
 import {
   type Group,
   type PluginConfig,
-  type RunnerConfig,
   pluginConfigSchema,
 } from '@code-pushup/models';
 import { MEMFS_VOLUME } from '@code-pushup/test-utils';
 import { jsPackagesPlugin } from './js-packages-plugin.js';
 
-vi.mock('./runner/index.ts', () => ({
-  createRunnerConfig: vi.fn().mockReturnValue({
-    command: 'node',
-    outputFile: 'runner-output.json',
-  } satisfies RunnerConfig),
-}));
-
 describe('jsPackagesPlugin', () => {
   it('should initialise the plugin without a given config for NPM', async () => {
     vol.fromJSON(
@@ -60,7 +52,7 @@ describe('jsPackagesPlugin', () => {
         title: 'JS Packages',
         audits: expect.any(Array),
         groups: expect.any(Array),
-        runner: expect.any(Object),
+        runner: expect.any(Function),
       }),
     );
   });

packages/plugin-js-packages/src/lib/js-packages-plugin.unit.test.ts

@@ -1,15 +1,9 @@
-import { writeFile } from 'node:fs/promises';
 import path from 'node:path';
-import type { RunnerConfig, RunnerFilesPaths } from '@code-pushup/models';
+import type { RunnerFunction } from '@code-pushup/models';
 import {
   asyncSequential,
-  createRunnerFiles,
-  ensureDirectoryExists,
   executeProcess,
-  filePathToCliArg,
   objectFromEntries,
-  objectToCliArgs,
-  readJsonFile,
 } from '@code-pushup/utils';
 import {
   type AuditSeverity,
@@ -26,54 +20,33 @@ import type { AuditResult } from './audit/types.js';
 import { outdatedResultToAuditOutput } from './outdated/transform.js';
 import { getTotalDependencies } from './utils.js';
 
-export async function createRunnerConfig(
-  scriptPath: string,
+export function createRunnerFunction(
   config: FinalJSPackagesPluginConfig,
-): Promise<RunnerConfig> {
-  const { runnerConfigPath, runnerOutputPath } = await createRunnerFiles(
-    'js-packages',
-    JSON.stringify(config),
-  );
-
-  return {
-    command: 'node',
-    args: [
-      filePathToCliArg(scriptPath),
-      ...objectToCliArgs({ runnerConfigPath, runnerOutputPath }),
-    ],
-    configFile: runnerConfigPath,
-    outputFile: runnerOutputPath,
-  };
-}
-
-export async function executeRunner({
-  runnerConfigPath,
-  runnerOutputPath,
-}: RunnerFilesPaths): Promise<void> {
-  const {
-    packageManager,
-    checks,
-    auditLevelMapping,
-    packageJsonPath,
-    dependencyGroups: depGroups,
-  } = await readJsonFile<FinalJSPackagesPluginConfig>(runnerConfigPath);
+): RunnerFunction {
+  return async () => {
+    const {
+      packageManager,
+      checks,
+      auditLevelMapping,
+      packageJsonPath,
+      dependencyGroups: depGroups,
+    } = config;
 
-  const auditResults = checks.includes('audit')
-    ? await processAudit(
-        packageManager,
-        depGroups,
-        auditLevelMapping,
-        packageJsonPath,
-      )
-    : [];
+    const auditResults = checks.includes('audit')
+      ? await processAudit(
+          packageManager,
+          depGroups,
+          auditLevelMapping,
+          packageJsonPath,
+        )
+      : [];
 
-  const outdatedResults = checks.includes('outdated')
-    ? await processOutdated(packageManager, depGroups, packageJsonPath)
-    : [];
-  const checkResults = [...auditResults, ...outdatedResults];
+    const outdatedResults = checks.includes('outdated')
+      ? await processOutdated(packageManager, depGroups, packageJsonPath)
+      : [];
 
-  await ensureDirectoryExists(path.dirname(runnerOutputPath));
-  await writeFile(runnerOutputPath, JSON.stringify(checkResults));
+    return [...auditResults, ...outdatedResults];
+  };
 }
 
 async function processOutdated(