Indentation of non-apache commands

[anton-schieber]

            migrationBuilder.Sql(@"
                SELECT create_hypertable('test.""orders""', 'timestamp', chunk_time_interval => INTERVAL '7 day');
                DO $$
DECLARE
    license TEXT;
BEGIN
    license := current_setting('timescaledb.license', true);
    
    IF license IS NULL OR license != 'apache' THEN
        EXECUTE 'ALTER TABLE ""test"".""orders"" SET (timescaledb.compress = true)';
    ELSE
        RAISE WARNING 'Skipping Community Edition features (compression, chunk skipping) - not available in Apache Edition';
    END IF;
END $$;

            ");

Should be:

            migrationBuilder.Sql(@"
                SELECT create_hypertable('test.""orders""', 'timestamp', chunk_time_interval => INTERVAL '7 day');
                DO $$
                DECLARE
                    license TEXT;
                BEGIN
                    license := current_setting('timescaledb.license', true);
    
                    IF license IS NULL OR license != 'apache' THEN
                        EXECUTE 'ALTER TABLE ""test"".""orders"" SET (timescaledb.compress = true)';
                    ELSE
                        RAISE WARNING 'Skipping Community Edition features (compression, chunk skipping) - not available in Apache Edition';
                    END IF;
                END $$;
            ");

[anton-schieber]

Seems like an issue in SqlBuilderHelper: BuildQueryString OR I guess the structure the statements are fed in

Since its considered 1 statement instead of an array of statements it doesnt add the indent?

[sebastian-ederer]

Yes, that's true. The issue is that the IndentedStringBuilder can't handle the indentation correctly when you append whole statements instead of new lines. However, when the MigrationCommandListBuilder was used not appending whole statements caused errors, when I remember correctly.

Note: The IndentedStringBuilder is used when generating migrations with dotnet ef add migration and the MigrationCommandListBuilder when using Database.EnsureCreatedAsync(). Not sure if it is also used when calling Database.MigrateAsync().

However, after some time I decided that other bugs and features are more important for now.