Modifying Localization Files – Best Practices

[PretzelWeaver]

I would like to modify some text in the localization files. Since I’m fairly new to GitHub, I’m wondering what best practices I should follow.

I don’t want to parse every file in one go, but prefer to approach it as a long-term project. I understand that I need to modify my fork of the project and then submit pull requests. But how frequently should I submit them?

[cloudwu]

You can create a pull request , and convert it to a draft , and then submit the following commits.

When you are ready, you can mark it as "ready for review".

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request

btw, If you want to stay in sync with the master branch while maintaining your PR, it's best to create a branch first and commit your changes on that branch.

You can safely submit directly to the master branch if you're not familiar with Git—since the project isn't expected to have many concurrent contributors right now.

[PretzelWeaver]

Forks, branches, pull requests... I do need baby steps for this... ;)

What I’ve done is fork the whole project. Now, I’m editing the english.dl file in my master branch. After each editing session, I commit the changes to my master branch, then create a pull request for the commits that are ahead.

Is this okay?

BTW, I’ll read your recommended doc soon.

[yuchanns]

Since you mentioned you're new to GitHub, I assume you're not familiar with the git tool and are working through the Web UI.

0. Navigate to your branches page: https://github.com/PretzelWeaver/deepfuture/branches
1. Click the button 'New branch'.
2. Select the upstream repository as the source.
3. Create new branch.

4. Then you're able to switch the branch in the homepage of your fork.

5. Commit your changes, submit a draft PR.
6. Mark it ready to review once it's finished.
7. (Optional) After it is merged, you'll see a 'Delete your branch' button at the bottom of the PR page—hit to delete.
8. Create a new branch to start a new working thread.