test: gzip

Author: brettz9

eslint.config.js

@@ -11,7 +11,7 @@ export default [
             globals: globals.node,
             parserOptions: {
                 sourceType: 'module',
-                ecmaVersion: 2022
+                ecmaVersion: 2024
             }
         },
         rules: {

lib/node-static.js

@@ -228,7 +228,9 @@ class Server {
         const enable = this.options.gzip;
         if(enable &&
             (typeof enable === 'boolean' ||
-                (contentType && (enable instanceof RegExp) && enable.test(contentType)))) {
+                (contentType && (enable instanceof RegExp) &&
+                    enable.test(contentType)))
+        ) {
             const acceptEncoding = req.headers['accept-encoding'];
             return acceptEncoding && acceptEncoding.includes('gzip');
         }

test/integration/binary.js

@@ -240,6 +240,33 @@ describe('node-static (CLI)', function () {
             assert.equal(text, 'hello world', 'should respond with hello world');
         });
 
+        it('serving file within directory and gzip but without gzip accept request', async function () {
+            const {response /* , stdout */} = await spawnConditional(binFile, [
+                '-p', this.port, fixturePath, '--gzip'
+            ], timeout - 9000, {
+                condition: /serving ".*?"/,
+                action: (/* err, stdout */) => {
+                    return fetch(
+                        `http://localhost:${this.port}/hello.txt`, {
+                            headers: {
+                                'accept-encoding': 'nothing'
+                            }
+                        }
+                    );
+                }
+            });
+
+            const {status} = response;
+            const contentType = response.headers.get('content-type');
+            const contentEncoding = response.headers.get('content-encoding');
+            const text = await response.text();
+
+            assert.equal(status, 200, 'should respond with 200');
+            assert.equal(contentType, 'text/plain', 'should respond with text/plain');
+            assert.equal(contentEncoding, null, 'should not respond with gzip encoding');
+            assert.equal(text, 'hello world', 'should respond with hello world');
+        });
+
         it('serves custom cache', async function () {
             const {response: responses /* , stdout */} = await spawnConditional(binFile, [
                 '-p', this.port, '--cache', JSON.stringify({

test/integration/node-static-test.js

@@ -158,6 +158,25 @@ describe('node-static', function () {
             assert.equal(response.headers.get('server'), 'own header', 'should contain custom server header');
             assert.equal(await response.text(), 'hello world', 'should respond with hello world');
         });
+
+        it('serving hello.txt with non-accepting gzip', async function (){
+            fileServer = new statik.Server(__dirname + '/../fixtures', {
+                gzip: /special-encoding/v
+            });
+
+            const response = await fetch(this.getTestServer() + '/hello.txt', {
+                headers: {
+                    'accept-encoding': 'gzip'
+                }
+            });
+            const contentEncoding = response.headers.get('content-encoding');
+
+            assert.equal(response.status, 200, 'should respond with 200');
+            assert.equal(response.headers.get('content-type'), 'text/plain', 'should respond with text/plain');
+            assert.equal(contentEncoding, null, 'should not respond with gzip encoding');
+            assert.equal(await response.text(), 'hello world', 'should respond with hello world');
+        });
+
         it('serving first 5 bytes of hello.txt', async function () {
             fileServer = new statik.Server(__dirname + '/../fixtures');
             const options = {