make compatibilityChecker robust if v2 api is disabled

Author: Lokowandtg

cloudfoundry-client-reactor/src/main/java/org/cloudfoundry/reactor/client/CloudFoundryClientCompatibilityChecker.java

@@ -39,7 +39,19 @@ final class CloudFoundryClientCompatibilityChecker {
     void check() {
         this.info
                 .get(GetInfoRequest.builder().build())
-                .map(response -> Version.valueOf(response.getApiVersion()))
+                .map(
+                        response -> {
+                            String version = response.getApiVersion();
+                            if (version == null || version.isEmpty()) {
+                                if ("CF API v2 is disabled".equals(response.getSupport())) {
+                                    this.logger.warn(
+                                            "calling v2 info endpoint but CF API v2 is disabled",
+                                            response);
+                                }
+                                return Version.of(0, 0, 0);
+                            }
+                            return Version.valueOf(version);
+                        })
                 .zipWith(Mono.just(Version.valueOf(CloudFoundryClient.SUPPORTED_API_VERSION)))
                 .subscribe(
                         consumer(

integration-test/src/test/java/org/cloudfoundry/IntegrationTestConfiguration.java

@@ -468,7 +468,20 @@ Version serverVersion(@Qualifier("admin") CloudFoundryClient cloudFoundryClient)
         return cloudFoundryClient
                 .info()
                 .get(GetInfoRequest.builder().build())
-                .map(response -> Version.valueOf(response.getApiVersion()))
+                .map(
+                        response -> {
+                            String version = response.getApiVersion();
+                            if (version == null || version.isEmpty()) {
+                                this.logger.warn(
+                                        "calling v2 info endpoint but CF API v2 is disabled");
+                                return new Version.Builder()
+                                        .setMajorVersion(0)
+                                        .setMinorVersion(0)
+                                        .setPatchVersion(0)
+                                        .build();
+                            }
+                            return Version.valueOf(version);
+                        })
                 .doOnSubscribe(s -> this.logger.debug(">> CLOUD FOUNDRY VERSION <<"))
                 .doOnSuccess(r -> this.logger.debug("<< CLOUD FOUNDRY VERSION >>"))
                 .block();

integration-test/src/test/java/org/cloudfoundry/client/v2/InfoTest.java

@@ -41,7 +41,13 @@ public void info() {
                 .consumeNextWith(
                         response -> {
                             Version expected = Version.valueOf(SUPPORTED_API_VERSION);
-                            Version actual = Version.valueOf(response.getApiVersion());
+                            Version actual;
+                            String version = response.getApiVersion();
+                            if (version == null || version.isEmpty()) {
+                                actual = Version.of(0, 0, 0);
+                            } else {
+                                actual = Version.valueOf(version);
+                            }
 
                             assertThat(actual).isLessThanOrEqualTo(expected);
                         })