Skip to content

Commit 7bb67aa

Browse files
committed
ci: move continue-on-error from job level to step level
Job-level continue-on-error only prevents workflow failure but the job itself still reports as failed, which blocks PRs when the job is a required status check. Moving it to the step level makes the job conclude as success while still surfacing failures in the step output. Also re-enables detect-breaking-changes (was disabled with if: false) with step-level soft-fail so it runs but does not block. Refs: APIX-852
1 parent 9f99d4b commit 7bb67aa

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ jobs:
9797
run: ./scripts/bootstrap
9898

9999
- name: Run tests
100+
continue-on-error: true
100101
run: ./scripts/test
101102
env:
102103
UV_PYTHON: ">=3.9.0"

.github/workflows/detect-breaking-changes.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ jobs:
99
detect_breaking_changes:
1010
runs-on: 'ubuntu-latest'
1111
name: detect-breaking-changes
12-
if: false
1312
permissions:
1413
contents: read
1514
steps:
@@ -29,10 +28,12 @@ jobs:
2928
- name: Install dependencies
3029
run: uv sync --all-extras
3130
- name: Detect removed symbols
31+
continue-on-error: true
3232
run: |
3333
uv run python scripts/detect-breaking-changes.py "${{ github.event.pull_request.base.sha }}"
3434
3535
- name: Detect breaking changes
36+
continue-on-error: true
3637
run: |
3738
# Try to check out previous versions of the breaking change detection script. This ensures that
3839
# we still detect breaking changes when entire files and their tests are removed.

0 commit comments

Comments
 (0)