Skip to content

fix missing catagories dependency this will unblock Ascent building for CIO Cirrus platform #284

@mjperrins

Description

@mjperrins

Consuming iascable in ascent and getting the following error


src/helpers/services.helper.ts:119:36 - error TS2339: Property 'categories' does not exist on type 'Catalog'.

119     const cats: CatExt[] = catalog.categories;
                                       ~~~~~~~~~~

src/helpers/services.helper.ts:355:17 - error TS2339: Property 'categories' does not exist on type 'Catalog'.

355         catalog.categories.forEach(category => {
                    ~~~~~~~~~~

src/helpers/services.helper.ts:355:36 - error TS7006: Parameter 'category' implicitly has an 'any' type.

355         catalog.categories.forEach(category => {
                                       ~~~~~~~~

src/helpers/services.helper.ts:356:61 - error TS7006: Parameter 'module' implicitly has an 'any' type.

356             if (category.modules) category.modules.forEach((module) => {

The fix seems to be 👍🏻

  1. Add `catagories to V2Model
export interface CatalogV2Model extends CustomResourceDefinition {
    modules: Module[];
    providers?: CatalogProviderModel[];
    aliases?: ModuleIdAlias[];
    boms: BillOfMaterialEntry[];
    categories: CatalogCategoryModel[];
}
  1. Add catagories to Catalog model
    categories: CatalogCategoryModel[];

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions