-
-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Labels
component: UIIssues related to changing UIIssues related to changing UIgood first issueGood for newcomersGood for newcomerspriority: lowIssues with low priority. Most like will never be done.Issues with low priority. Most like will never be done.type: refactoringImproving the code quality w/o changing functionalityImproving the code quality w/o changing functionality
Description
Create a widget that should do the following:
- Takes
Pretty.Layout.t - Wraps it around in a round border by adding a single space to the left and right sides
Put it in widget/generic.ml module.
The idea is to replace hardcoded widgets like this one:
github-tui/lib/tui/widget/issue.ml
Lines 10 to 18 in deb91b8
| let filter_open = | |
| fmt_filter | |
| ~style:Style.issue_open | |
| ~is_selected:(current_filter = Model.Issue.filter_open) | |
| [ "╭──────────╮"; | |
| "│ Open o │"; | |
| "╰──────────╯"; | |
| ] [@@ocamlformat "disable"] | |
| in |
So let's also replace these three selector widgets once this new one is introduced.
Metadata
Metadata
Assignees
Labels
component: UIIssues related to changing UIIssues related to changing UIgood first issueGood for newcomersGood for newcomerspriority: lowIssues with low priority. Most like will never be done.Issues with low priority. Most like will never be done.type: refactoringImproving the code quality w/o changing functionalityImproving the code quality w/o changing functionality