linting

Author: dandye

detect/v1alpha/bulk_update_alerts.py

@@ -117,4 +117,4 @@
           args.comment,
           args.root_cause,
       )
-      print(json.dumps(a_list, indent=2))
+      print(json.dumps(a_list, indent=2))

detect/v1alpha/get_retrohunt.py

@@ -87,8 +87,10 @@ def get_retrohunt(
   """
   base_url_with_region = regions.url_always_prepend_region(
       CHRONICLE_API_BASE_URL, proj_region)
+  # pylint: disable=line-too-long
   parent = f"projects/{proj_id}/locations/{proj_region}/instances/{proj_instance}"
   url = f"{base_url_with_region}/v1alpha/{parent}/rules/{rule_id}/retrohunts/{op_id}"
+  # pylint: enable=line-too-long
 
   response = http_session.request("GET", url)
   if response.status_code >= 400:

detect/v1alpha/get_rule.py

@@ -48,31 +48,30 @@ def get_rule(
 ) -> Mapping[str, Any]:
   """Gets a rule using the Get Rule API.
 
-    Args:
-        http_session: Authorized session for HTTP requests.
-        proj_id: GCP project id or number to which the target instance belongs.
-        proj_instance: Customer ID (uuid with dashes) for the Chronicle instance.
-        proj_region: Region where the target project is located.
-        rule_id: Unique ID of the detection rule to retrieve ("ru_<UUID>" or
-            "ru_<UUID>@v_<seconds>_<nanoseconds>"). If a version suffix isn't
-            specified we use the rule's latest version.
-
-    Returns:
-        Dictionary containing the rule's information.
-
-    Raises:
-        requests.exceptions.HTTPError: HTTP request resulted in an error
-            (response.status_code >= 400).
-
-    Requires the following IAM permission on the parent resource:
-    chronicle.rules.get
-    """
+  Args:
+    http_session: Authorized session for HTTP requests.
+    proj_id: GCP project id or number to which the target instance belongs.
+    proj_instance: Customer ID (uuid w/ dashes) for the Chronicle instance.
+    proj_region: Region where the target project is located.
+    rule_id: Unique ID of the detection rule to retrieve ("ru_<UUID>" or
+        "ru_<UUID>@v_<seconds>_<nanoseconds>"). If a version suffix isn't
+        specified we use the rule's latest version.
+
+  Returns:
+    Dictionary containing the rule's information.
+
+  Raises:
+    requests.exceptions.HTTPError: HTTP request resulted in an error
+        (response.status_code >= 400).
+
+  Requires the following IAM permission on the parent resource:
+  chronicle.rules.get
+  """
   base_url_with_region = regions.url_always_prepend_region(
       CHRONICLE_API_BASE_URL, proj_region)
-  # pylint: disable=line-too-long
+  # pylint: disable=line-too-long-next
   parent = f"projects/{proj_id}/locations/{proj_region}/instances/{proj_instance}"
   url = f"{base_url_with_region}/v1alpha/{parent}/rules/{rule_id}"
-  # pylint: enable=line-too-lon
 
   response = http_session.request("GET", url)
   if response.status_code >= 400:

iocs/v1alpha/get_ioc.py

@@ -16,6 +16,7 @@
 """Get a single IoC from Chronicle."""
 
 from common import regions
+from typing import Any, Mapping
 from google.auth.transport import requests
 
 CHRONICLE_API_BASE_URL = "https://chronicle.googleapis.com"

search/v1alpha/asset_events_find.py

@@ -53,27 +53,27 @@ def find_asset_events(http_session: requests.AuthorizedSession,
                       max_results: Optional[int] = None) -> None:
   """Find asset events in Chronicle using the Legacy Find Asset Events API.
 
-    Args:
-        http_session: Authorized session for HTTP requests.
-        proj_id: GCP project id or number to which the target instance belongs.
-        proj_instance: Customer ID (uuid with dashes) for the instance.
-        proj_region: region in which the target project is located.
-        asset_indicator: JSON str containing the asset indicator to search for.
-        start_time: Start time in RFC3339 format (e.g., "2024-01-01T00:00:00Z").
-        end_time: End time in RFC3339 format (e.g., "2024-01-02T00:00:00Z").
-        reference_time: Optional reference time in RFC3339 format for
-          asset aliasing.
-        max_results: Optional maximum number of results to return
-          (default: 10000, max: 250000).
-
-    Raises:
-        requests.exceptions.HTTPError: HTTP request resulted in an error
-            (response.status_code >= 400).
-        ValueError: If the time format is invalid.
-
-    Requires the following IAM permission on the instance resource:
-    chronicle.legacies.legacyFindAssetEvents
-    """
+  Args:
+    http_session: Authorized session for HTTP requests.
+    proj_id: GCP project id or number to which the target instance belongs.
+    proj_instance: Customer ID (uuid with dashes) for the instance.
+    proj_region: region in which the target project is located.
+    asset_indicator: JSON str containing the asset indicator to search for.
+    start_time: Start time in RFC3339 format (e.g., "2024-01-01T00:00:00Z").
+    end_time: End time in RFC3339 format (e.g., "2024-01-02T00:00:00Z").
+    reference_time: Optional reference time in RFC3339 format for
+      asset aliasing.
+    max_results: Optional maximum number of results to return
+      (default: 10000, max: 250000).
+
+  Raises:
+    requests.exceptions.HTTPError: HTTP request resulted in an error
+        (response.status_code >= 400).
+    ValueError: If the time format is invalid.
+
+  Requires the following IAM permission on the instance resource:
+  chronicle.legacies.legacyFindAssetEvents
+  """
   # Validate and parse the times to ensure they're in RFC3339 format
   for time_str in [start_time, end_time, reference_time
                   ] if reference_time else [start_time, end_time]: