MEDIUM: server: remove a useless memset() in srv_update_check_addr_port.

cognet · cognet · commit 0e36267aaccb · 2026-03-26T16:43:48.000+01:00
Remove a memset that should not be there, and tries to zero a NULL pointer.
diff --git a/src/server.c b/src/server.c
@@ -4667,7 +4667,6 @@ const char *srv_update_check_addr_port(struct server *s, const char *addr, const
 		goto out;
 	}
 	if (addr) {
-		memset(&sk, 0, sizeof(struct sockaddr_storage));
 		sk = str2sa_range(addr, NULL, NULL, NULL, NULL, &proto, NULL, NULL, NULL, NULL, NULL, 0);
 		if (sk == NULL) {
 			chunk_appendf(msg, "invalid addr '%s'", addr);

Original file line number	Diff line number	Diff line change
`@@ -4667,7 +4667,6 @@ const char srv_update_check_addr_port(struct server s, const char *addr, const`
`4667`	`4667`	`goto out;`
`4668`	`4668`	`}`
`4669`	`4669`	`if (addr) {`
`4670`		`- memset(&sk, 0, sizeof(struct sockaddr_storage));`
`4671`	`4670`	`sk = str2sa_range(addr, NULL, NULL, NULL, NULL, &proto, NULL, NULL, NULL, NULL, NULL, 0);`
`4672`	`4671`	`if (sk == NULL) {`
`4673`	`4672`	`chunk_appendf(msg, "invalid addr '%s'", addr);`