Cannot read properties of null (reading 'length')

[h3rmanj]

After updating to v1.5.0 and trying commitMode: github-api, I get this output:

Run changesets/action@746c25e23caa47dceb6a48ee85b4cbc5a9f5f293
  with:
    publish: npm run release
    commit: chore: version packages
    commitMode: github-api
    setupGitUser: true
    createGithubReleases: true
  env:
    NPM_CONFIG_USERCONFIG: /home/runner/work/_temp/.npmrc
    NODE_AUTH_TOKEN: ***
    GITHUB_TOKEN: ***
setting git user
setting GitHub credentials
/opt/hostedtoolcache/node/22.15.0/x64/bin/node /home/runner/work/***/***/node_modules/@changesets/cli/bin.js version
🦋  All files have been updated. Review them and commit at your leisure
Error: TypeError: Cannot read properties of null (reading 'length')
Error: Cannot read properties of null (reading 'length')

Unsure which .length call is throwing, as I found some different ones when searching for .length.

Not sure if this is related could be triggered by #391, any ideas @s0?

[h3rmanj]

Given that it runs @changeset/cli/bin.js version, I assume it gets at least to this line.

The next .length access is this line from the getChangelogEntry call.

I'll try some variations of inputs for the job, and check if our changelog file might be damaged.

[h3rmanj]

Removing commitMode (setting it to default git-cli), makes the job run again it seems. Although I want to be able to create with github api, to trigger tag workflows.

We use a token from a GitHub App, is there any permissions that would be needed in addition when using commitMode: github-api?

[h3rmanj]

I debugged some more, by calling runVersion locally with the proper arguments.

It seems this happens in @changesets/ghcommit, during git.walk.

This is the output I got:

TypeError: Cannot read properties of null (reading 'length')
    at GitWalkerFs.content (/home/***/projects/changesets-action/dist/index.js:78124:43)
    at async /home/***/projects/changesets-action/dist/index.js:78151:35
    at async /home/***/projects/changesets-action/dist/index.js:74796:22 {
  caller: 'git.walk'
}

Tried testing further to see exactly which folder is crashing. It was node_modules/docs which is weird, because it's gitignored, and a symlink (docs is one of the projects in the repo).

Further it seems it's specifically the call to await workdir?.old() that triggers this.

It seems to happen because the check for isIgnored call happens after the workdir?.old() call. Changed the order locally and it ran fine.

I'll create a PR.

[h3rmanj]

@s0 @Andarist

Got the PR up in changesets/ghcommit.

I'm guessing it has to be merged, then published, bump the version in this action, and publish a new version of the action?

[Andarist]

I'm guessing it has to be merged, then published, bump the version in this action, and publish a new version of the action?

Yes.