Skip to content

Commit 48f7c4e

Browse files
committed
update errors; add nil check
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
1 parent 560d7c8 commit 48f7c4e

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

app/controlplane/internal/service/attestation.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ func (s *AttestationService) Init(ctx context.Context, req *cpAPI.AttestationSer
178178
backend, err := s.casUC.FindDefaultOrFallbackBackend(context.Background(), robotAccount.OrgID)
179179
if err != nil {
180180
if biz.IsNotFound(err) {
181-
return nil, errors.NotFound("not found", "default CAS backend not found")
181+
return nil, cpAPI.ErrorCasBackendErrorReasonRequired(err.Error())
182182
} else if biz.IsErrValidation(err) {
183-
return nil, err
183+
return nil, cpAPI.ErrorCasBackendErrorReasonInvalid(err.Error())
184184
}
185-
return nil, fmt.Errorf("failed to find CAS backend: %w", err)
185+
return nil, handleUseCaseErr(err, s.log)
186186
}
187187

188188
// Create workflowRun

app/controlplane/pkg/biz/casbackend.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,10 @@ func (uc *CASBackendUseCase) FindDefaultOrFallbackBackend(ctx context.Context, o
245245
return nil, err
246246
}
247247

248+
if defaultBackend == nil {
249+
return nil, NewErrNotFound("default CAS Backend")
250+
}
251+
248252
// Check if default backend is valid
249253
if defaultBackend.ValidationStatus == CASBackendValidationOK {
250254
return defaultBackend, nil

0 commit comments

Comments
 (0)