ENT-13826: Error on user-defined bundle/body with the name of a built-in func

Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>

Author: SimonThalvorsen

src/cfengine_cli/lint.py

@@ -492,6 +492,15 @@ def _lint_node(node: Node, policy_file: PolicyFile, state: State) -> int:
             f"Error: Bundle type must be one of ({', '.join(ALLOWED_BUNDLE_TYPES)}), not '{_text(node)}' {location}"
         )
         return 1
+    if state.strict and (
+        node.type in ("bundle_block_name", "body_block_name")
+        and _text(node) in BUILTIN_FUNCTIONS
+    ):
+        _highlight_range(node, lines)
+        print(
+            f"Error: {"Bundle" if "bundle" in node.type else "Body"} '{_text(node)}' shadows built-in function with the same name {location}"
+        )
+        return 1
     if node.type == "calling_identifier":
         name = _text(node)
         qualified_name = _qualify(name, state.namespace)

tests/lint/009_bundle_shadows_function.cf

@@ -0,0 +1,5 @@
+bundle agent isvariab
+{
+  reports:
+    "isvariab is not a built-in function";
+}

tests/lint/009_bundle_shadows_function.expected.txt

@@ -0,0 +1,6 @@
+
+bundle agent isvariable
+             ^--------^
+Error: Bundle 'isvariable' shadows built-in function with the same name at tests/lint/009_bundle_shadows_function.x.cf:1:14
+FAIL: tests/lint/009_bundle_shadows_function.x.cf (1 error)
+Failure, 1 error in total.

tests/lint/009_bundle_shadows_function.x.cf

@@ -0,0 +1,5 @@
+bundle agent isvariable
+{
+  reports:
+    "isvariable is a built-in function";
+}