ENT-13075: Error if user tries to call bundle inside custom promise

Ticket: ENT-13075

Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>

Author: SimonThalvorsen

src/cfengine_cli/lint.py

@@ -80,6 +80,14 @@ def _text(node):
     return node.text.decode()
 
 
+def _find_node_parent_type(node, parent_type):
+    current = node
+    while current is not None and current.type != parent_type:
+        current = current.parent
+
+    return current
+
+
 def _walk_generic(filename, lines, node, visitor):
     visitor(node)
     for node in node.children:
@@ -133,7 +141,6 @@ def _single_node_checks(filename, lines, node, user_definition, strict):
                 f"Error: Undefined promise type '{promise_type}' at {filename}:{line}:{column}"
             )
             return 1
-
     if node.type == "bundle_block_name":
         if _text(node) != _text(node).lower():
             _highlight_range(node, lines)
@@ -156,6 +163,24 @@ def _single_node_checks(filename, lines, node, user_definition, strict):
             )
             return 1
     if node.type == "calling_identifier":
+        if (
+            strict
+            and _text(node) in user_definition.get("all_bundle_names", set())
+            and (
+                (parent := _find_node_parent_type(node, "bundle_section")) is not None
+            )  # Find parent node with type
+            and (
+                (
+                    parent := _text(parent)[0 : _text(parent).index(":")]
+                )  # Extract the content of section until ':' for promise_type name
+                in user_definition.get("custom_promise_types", set())
+            )
+        ):
+            _highlight_range(node, lines)
+            print(
+                f"Error: Call to bundle ('{_text(node)}') inside custom promise: '{parent}' at at {filename}:{line}:{column}"
+            )
+            return 1
         if strict and (
             _text(node)
             not in BUILTIN_FUNCTIONS.union(