1316: New rule - value against library metadata#1680
Conversation
alexfurmenkov
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alexfurmenkov
changed the title
# Conflicts: # tests/resources/CoreIssue1316/test_dataset.json
alexfurmenkov
changed the title
| | | [Value Check with Variable Metadata](#value-check-with-variable-metadata) | | ||
| | | [Value Check against Define XML Variable](#value-check-against-define-xml-variable) | | ||
| | | [Value Check against Define XML VLM](#value-check-against-define-xml-vlm) | | ||
| | | [Value Check against Library Metadata](#value-check-against-library-metadata) | |
There was a problem hiding this comment.
You need to also add this rule type to Rule_Type.json. This is why the merge script is not finding anything.
| # merge dataset contents with library variable metadata | ||
| merged = data_contents_long_df.merge( | ||
| variables_metadata.data, | ||
| how="outer", |
There was a problem hiding this comment.
is there a reason this is an outer join versus a left join? The rules mentioned want to check if values are not present in the library. I dont think we want all the library metadata that isnt associated with a variable?
SFJohnson24
left a comment
SFJohnson24
left a comment
There was a problem hiding this comment.
I think we just want to change that join to left and this is good to go
|
@alexfurmenkov I was mistaken--this should be an outer join to allow checks when it exists in library but not as a value in the dataset. Apologies |
This reverts commit bc5cc32.
SFJohnson24
left a comment
SFJohnson24
left a comment
There was a problem hiding this comment.
This PR correctly implements the new rule type and builder as well as all the requisite additions--readme, schema, testing.
3 participants
dataset builder for new rule type.
test dataset with joined library metadata
1316_full.xlsx
and filtered dataset with VISIT/VISITNUM/VISITDY data (maybe it's more representative since it has library metadata filled)
1316_example.xlsx