Skip to content

1305: Fix type error in row number assignment to handle NaN values#1673

Merged
SFJohnson24 merged 3 commits into
mainfrom
1305-fix-type-error
Apr 21, 2026
Merged

1305: Fix type error in row number assignment to handle NaN values#1673
SFJohnson24 merged 3 commits into
mainfrom
1305-fix-type-error

Conversation

@alexfurmenkov
Copy link
Copy Markdown
Collaborator

No description provided.

@alexfurmenkov alexfurmenkov changed the title Fix type error in row number assignment to handle NaN values 1308: Fix type error in row number assignment to handle NaN values Mar 26, 2026
@alexfurmenkov alexfurmenkov linked an issue Mar 26, 2026 that may be closed by this pull request
@alexfurmenkov alexfurmenkov changed the title 1308: Fix type error in row number assignment to handle NaN values 1305: Fix type error in row number assignment to handle NaN values Mar 26, 2026
Copy link
Copy Markdown
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a description. I looked at connected issue and the title of the PR. I see you found a problem and did a fix. If you could add a small description of observed problem and what fix you applied for it, that would make understanding the PR easier for review.

@alexfurmenkov
Copy link
Copy Markdown
Collaborator Author

Hi @RamilCDISC,
The file that Hajime shared in the task did not reproduce the issue. I started trying to reproduce the problem myself, and I was able to do so - if I set data_contents_long_df['variable_name'] = '' in the debugger, the issue described by Hajime is reproduced.

@alexfurmenkov alexfurmenkov requested a review from RamilCDISC April 7, 2026 12:39
Copy link
Copy Markdown
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds a null check for robustness. The connected ticket issue was not reproduced. The PR enhances a check by adding a null check on top.

@SFJohnson24 SFJohnson24 merged commit c022168 into main Apr 21, 2026
12 checks passed
@SFJohnson24 SFJohnson24 deleted the 1305-fix-type-error branch April 21, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Value Check against Define XML Variable fires Error

3 participants