#710 Add CORE logo icon to executable builds and update README logo#1504
Conversation
RamilCDISC
left a comment
There was a problem hiding this comment.
Could you please update the Build custom executable workflow too?
RamilCDISC
left a comment
There was a problem hiding this comment.
I ran the custom executable build workflow and downloaded the zip. The executable in the zip did not have the provided icon. You can download the zip from here https://github.com/cdisc-org/cdisc-rules-engine/actions/runs/20699099226
I tried locally too on a mac. The executables did not have the icon.
RamilCDISC
left a comment
There was a problem hiding this comment.
Could you please update the commands in readme.md to show for mac too and i ran the workflow for linux here https://github.com/cdisc-org/cdisc-rules-engine/actions/runs/20829577911
The core executable still does not show the icon. You can download the zip from the link above.
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds core icon to the executables created through workflows and manually. The PR was validated by:
- Ensuring all relevant workflows were updated.
- Ensuring all documentation was updated.
- Ensuring windows, mac and linux all were converted in updates.
- Tested the linux executable by running build_version.yml workflow.
- Tested mac and windows by building executables locally.
Note: For linux the icon may not be visible because file managers there typically display generic icons for executables. For mac add '--windowed' to the command to create core.app, as mac shows icon only on .app.
This PR for Issue #710 adds the CORE logo as the executable icon for PyInstaller builds and updates the README to display the CORE logo instead of the CDISC logo. The icon file (CORE_logo_sm.ico) has been added to resources/assets/ and integrated into all build configurations: Dockerfile.build, GitHub Actions workflows (build-binary.yml), and README documentation (PyInstaller commands for both Linux and Windows). The README logo at the top has been updated to use the CORE logo image (CORE_logo_sm.png). These changes ensure that future releases will display the CORE logo on Windows executables and in the repository README.