Add column config sidebar#4877
Conversation
burieberry
force-pushed
the
cs-11052-column-config-sidebar
branch
from
0e1dc5c to
1366877
Compare
Preview deploymentsHost Test Results 1 files 1 suites 1h 47m 15s ⏱️ Results for commit 616c54e. Realm Server Test Results 1 files ±0 1 suites ±0 10m 23s ⏱️ -7s Results for commit 616c54e. ± Comparison against earlier commit 3f02c26. |
burieberry
force-pushed
the
cs-11052-column-config-sidebar
branch
from
1366877 to
3b20de8
Compare
burieberry
force-pushed
the
cs-11052-column-config-sidebar
branch
2 times, most recently
from
e1bae2c to
4e3aa7d
Compare
burieberry
force-pushed
the
cs-11052-column-config-sidebar
branch
from
4e3aa7d to
3f02c26
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 616c54efaf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const colEl = container.querySelector( | ||
| `[data-kanban-column="${column}"]`, | ||
| `[data-kanban-column="${columnId}"]`, | ||
| ) as HTMLElement | null; |
There was a problem hiding this comment.
The drag manager now interpolates columnId directly into querySelector selectors ([data-kanban-column="${columnId}"]). Column IDs come from user-editable status values, so IDs containing selector metacharacters (for example quotes, ], or ?) will produce an invalid selector and throw a SyntaxError, breaking drag/drop and keyboard placement updates at runtime. Use CSS.escape(columnId) (or avoid selector string interpolation) before querying.
Useful? React with 👍 / 👎.
| <KanbanColumnConfigSidebar | ||
| @columns={{this.columns}} | ||
| @onClose={{this.toggleSidebar}} | ||
| @onToggleCollapsed={{this.handleToggleCollapsed}} | ||
| @onLabelChange={{this.handleLabelChange}} |
There was a problem hiding this comment.
In KanbanBoard isolated view, the sidebar is rendered without @hideEmpty and @cardCounts, so empty-column visibility toggles remain enabled even when the toolbar's Hide empty switch is on. Because handleToggleCollapsed still flips collapsed, users can re-show empty columns while hideEmpty is true, which violates the hide-empty contract and diverges from IssueTracker behavior.
Useful? React with 👍 / 👎.
1 participant
Uh oh!
There was an error while loading. Please reload this page.