Replies: 2 comments
-
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Hum ... I'm a bit confused because it seems to came from syntax used to mark an action skipped When I use the
Related to issue #309 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment


Uh oh!
There was an error while loading. Please reload this page.
-
I've recently, implemented my plugin https://github.com/llaville/captainhook-bin-plugin into a real project, and I was surprised by output. Here is a screenshot of what I got :
First action skipped is as expected because I've not installed PHPLint, but I don't understand second action that should print also a skipped result, because PHP-CS-Fixer is not installed too.
Origin came from : https://github.com/captainhook-git/captainhook/blob/5.28.5/src/Runner/Hook.php#L314-L317
I've checked my CaptainHook config files, and all seems OK for me :
Here are a summary of these (only
pre-commithooks are used here due to command tested)main
captainhook.json{ "config": { "verbosity": "normal", "allow-failure": false, "ansi-colors": true, "bootstrap": "autoload.php", "git-directory": ".git", "fail-on-first-error": true, "plugins": [ { "plugin": "\\Bartlett\\CaptainHookBinPlugin\\BinPlugin", "options": { "binary-directory": "{$ENV|value-of:VENDOR_BIN_DIR|default:vendor/bin}" } } ], "includes": [ ".config/captainhook/pre-push.phpstan.json", ".config/captainhook/pre-push.phpunit.json", ".config/captainhook/pre-commit.phplint.json", ".config/captainhook/pre-commit.phpcs-fixer.json" ] } }.config/captainhook/pre-commit.phplint.json{ "pre-commit": { "enabled": true, "actions": [ { "action": "{$ENV|value-of:VENDOR_BIN_DIR|default:vendor/bin/}phplint --configuration=.github/linters/.phplint.yml --ansi {$STAGED_FILES|of-type:php|separated-by: }", "config": { "label": "Lint Files (with PHPLint)" }, "options": { "package-require": [ "overtrue/phplint", "^9.7" ] } } ] } }.config/captainhook/pre-commit.phpcs-fixer.json{ "pre-commit": { "enabled": true, "actions": [ { "action": "{$ENV|value-of:VENDOR_BIN_DIR|default:vendor/bin/}php-cs-fixer fix --dry-run --config=.github/linters/.php-cs-fixer.dist.php --using-cache=no --verbose --ansi {$STAGED_FILES|of-type:php|separated-by: }", "config": { "label": "Checks Coding Standard (with PHP-CS-Fixer)" }, "options": { "package-require": [ "friendsofphp/php-cs-fixer", "^3.5" ] } } ] } }Beta Was this translation helpful? Give feedback.
All reactions