Import splits multiline history entries as multiple commands

[iloveitaly]

This is documented here but it would be great if there was an option to either (a) omit multiline commands or (b) properly handle them. I may have some time to help with this; mind pointing me in the right direction?

[cantino]

Thanks @iloveitaly, and sorry for the delay. There are probably a few places this needs to be handled:

1. When importing existing history, which means updating the history file parsers in https://github.com/cantino/mcfly/blob/master/src/shell_history.rs
2. When adding a new command to the DB (in mcfly.fish as '$argv[1]' for fish, handled in https://github.com/cantino/mcfly/blob/master/src/settings.rs#L344C40-L347C22 for bash and zsh, and possibly not parsing right until 1 is done above)
3. Displaying in the UI
4. Outputting commands back to the terminal https://github.com/cantino/mcfly/blob/master/src/main.rs#L48

[last-partizan]

I was exploring this also, and here's some examples from atuin (they have proper parsing of multiline commands in zsh):

https://github.com/atuinsh/atuin/blob/main/crates/atuin-client/src/import/zsh.rs

Also, note how they're adding commands to history:

https://github.com/atuinsh/atuin/blob/main/crates/atuin/src/shell/atuin.zsh

Instead of relying entirely on precmd and parsing, they use combination of preexec and precmd to save it.

(I'm not patient enough to finish this task, but maybe it can be useful for the next person who wants this fixed :) )