test: add NIP-11 parity coverage and update support docs

Author: a-khushal

CONFIGURATION.md

@@ -127,11 +127,15 @@ The settings below are listed in alphabetical order by name. Please keep this ta
 
 | Name                                        | Description                                                                   |
 |---------------------------------------------|-------------------------------------------------------------------------------|
+| info.banner                                 | Public banner image URL for the relay information document. |
 | info.contact                                | Relay operator's contact. (e.g. mailto:operator@relay-your-domain.com) |
 | info.description                            | Public description of your relay. (e.g. Toronto Bitcoin Group Public Relay) |
+| info.icon                                   | Public icon image URL for the relay information document. |
 | info.name                                   | Public name of your relay. (e.g. TBG's Public Relay) |
 | info.pubkey                                 | Relay operator's Nostr pubkey in hex format. |
 | info.relay_url                              | Public-facing URL of your relay. (e.g. wss://relay.your-domain.com) |
+| info.self                                   | Relay pubkey in hex format for the relay information document `self` field. |
+| info.terms_of_service                       | Public URL to relay terms of service. |
 | limits.admissionCheck.ipWhitelist           | List of IPs (IPv4 or IPv6) to ignore rate limits. |
 | limits.admissionCheck.rateLimits[].period   | Rate limit period in milliseconds. |
 | limits.admissionCheck.rateLimits[].rate     | Maximum number of admission checks during period. |

README.md

@@ -49,7 +49,6 @@ NIPs with a relay-specific implementation are listed here.
 - [x] NIP-05: Mapping Nostr keys to DNS-based internet identifiers
 - [x] NIP-09: Event deletion
 - [x] NIP-11: Relay information document
-- [x] NIP-11a: Relay Information Document Extensions
 - [x] NIP-12: Generic tag queries
 - [x] NIP-13: Proof of Work
 - [x] NIP-15: End of Stored Events Notice

package.json

@@ -21,9 +21,7 @@
     44,
     45
   ],
-  "supportedNipExtensions": [
-    "11a"
-  ],
+  "supportedNipExtensions": [],
   "main": "src/index.ts",
   "scripts": {
     "dev": "node --env-file-if-exists=.env -r ts-node/register src/index.ts",

src/constants/base.ts

@@ -55,6 +55,7 @@ export enum EventTags {
 }
 
 export const ALL_RELAYS = 'ALL_RELAYS'
+export const DEFAULT_FILTER_LIMIT = 500
 
 export enum PaymentsProcessors {
   LNURL = 'lnurl',

src/handlers/request-handlers/root-request-handler.ts

@@ -4,6 +4,7 @@ import { path, pathEq } from 'ramda'
 import { createSettings } from '../../factories/settings-factory'
 import { escapeHtml } from '../../utils/html'
 import { FeeSchedule } from '../../@types/settings'
+import { DEFAULT_FILTER_LIMIT } from '../../constants/base'
 import { fromBech32 } from '../../utils/transform'
 import { getTemplate } from '../../utils/template-cache'
 import packageJson from '../../../package.json'
@@ -41,16 +42,16 @@ export const rootRequestHandler = (request: Request, response: Response, next: N
     const relayInformationDocument = {
       name,
       description,
-      banner,
-      icon,
+      ...(banner !== undefined ? { banner } : {}),
+      ...(icon !== undefined ? { icon } : {}),
       pubkey,
-      self,
+      ...(self !== undefined ? { self } : {}),
       contact,
       supported_nips: packageJson.supportedNips,
       supported_nip_extensions: packageJson.supportedNipExtensions,
       software: packageJson.repository.url,
       version: packageJson.version,
-      terms_of_service,
+      ...(terms_of_service !== undefined ? { terms_of_service } : {}),
       limitation: {
         max_message_length: settings.network.maxPayloadSize,
         max_subscriptions: settings.limits?.client?.subscription?.maxSubscriptions,
@@ -67,7 +68,7 @@ export const rootRequestHandler = (request: Request, response: Response, next: N
         payment_required: settings.payments?.enabled,
         created_at_lower_limit: createdAtLimits?.maxNegativeDelta,
         created_at_upper_limit: createdAtLimits?.maxPositiveDelta,
-        default_limit: 500,
+        default_limit: DEFAULT_FILTER_LIMIT,
         restricted_writes: hasWriteRestriction,
       },
       payments_url: paymentsUrl.toString(),

src/repositories/event-repository.ts

@@ -30,6 +30,7 @@ import {
 
 import {
   ContextMetadataKey,
+  DEFAULT_FILTER_LIMIT,
   EventDeduplicationMetadataKey,
   EventExpirationTimeMetadataKey,
   EventKinds,
@@ -76,7 +77,7 @@ export class EventRepository implements IEventRepository {
       if (typeof currentFilter.limit === 'number') {
         builder.limit(currentFilter.limit).orderBy('event_created_at', 'DESC').orderBy('event_id', 'asc')
       } else {
-        builder.limit(500).orderBy('event_created_at', 'asc').orderBy('event_id', 'asc')
+        builder.limit(DEFAULT_FILTER_LIMIT).orderBy('event_created_at', 'asc').orderBy('event_id', 'asc')
       }
 
       if (isTagQuery) {

test/integration/features/nip-11/nip-11.feature

@@ -9,6 +9,14 @@ Feature: NIP-11
     When a client requests the relay information document
     Then the supported_nips field matches the NIPs declared in package.json
 
+  Scenario: Relay information response includes required CORS headers
+    When a client requests the relay information document
+    Then the relay information response includes required NIP-11 CORS headers
+
+  Scenario: Relay information document includes NIP-11 limitation parity fields
+    When a client requests the relay information document
+    Then the limitation object contains NIP-11 parity fields and values
+
   Scenario: Relay does not return information document for a non-NIP-11 Accept header
     When a client requests the root path with Accept header "text/html"
     Then the response Content-Type does not include "application/nostr+json"

test/integration/features/nip-11/nip-11.feature.ts

@@ -3,6 +3,7 @@ import axios, { AxiosResponse } from 'axios'
 import chai from 'chai'
 
 import packageJson from '../../../../package.json'
+import { DEFAULT_FILTER_LIMIT } from '../../../../src/constants/base'
 import { createSettings } from '../../../../src/factories/settings-factory'
 
 chai.use(require('sinon-chai'))
@@ -70,3 +71,32 @@ Then('the limitation object contains a max_filters field', function(this: World<
   const expectedMaxFilters = createSettings().limits?.client?.subscription?.maxFilters
   expect(doc.limitation.max_filters).to.equal(expectedMaxFilters)
 })
+
+Then('the relay information response includes required NIP-11 CORS headers', function(
+  this: World<Record<string, any>>,
+) {
+  const headers = this.parameters.httpResponse.headers
+  expect(headers['access-control-allow-origin']).to.equal('*')
+  expect(headers['access-control-allow-headers']).to.equal('*')
+  expect(headers['access-control-allow-methods']).to.equal('GET, OPTIONS')
+})
+
+Then('the limitation object contains NIP-11 parity fields and values', function(this: World<Record<string, any>>) {
+  const doc = this.parameters.httpResponse.data
+  const settings = createSettings()
+  const eventLimits = settings.limits?.event
+
+  const expectedRestrictedWrites =
+    Boolean(settings.payments?.enabled && settings.payments?.feeSchedules?.admission?.some((fee) => fee.enabled)) ||
+    (eventLimits?.eventId?.minLeadingZeroBits ?? 0) > 0 ||
+    (eventLimits?.pubkey?.minLeadingZeroBits ?? 0) > 0 ||
+    (eventLimits?.pubkey?.whitelist?.length ?? 0) > 0 ||
+    (eventLimits?.pubkey?.blacklist?.length ?? 0) > 0 ||
+    (eventLimits?.kind?.whitelist?.length ?? 0) > 0 ||
+    (eventLimits?.kind?.blacklist?.length ?? 0) > 0
+
+  expect(doc.limitation.created_at_lower_limit).to.equal(eventLimits?.createdAt?.maxNegativeDelta)
+  expect(doc.limitation.created_at_upper_limit).to.equal(eventLimits?.createdAt?.maxPositiveDelta)
+  expect(doc.limitation.default_limit).to.equal(DEFAULT_FILTER_LIMIT)
+  expect(doc.limitation.restricted_writes).to.equal(expectedRestrictedWrites)
+})

test/unit/handlers/request-handlers/root-request-handler.spec.ts

@@ -7,6 +7,7 @@ const { expect } = chai
 
 import * as settingsFactory from '../../../../src/factories/settings-factory'
 import * as templateCache from '../../../../src/utils/template-cache'
+import { DEFAULT_FILTER_LIMIT } from '../../../../src/constants/base'
 import { rootRequestHandler } from '../../../../src/handlers/request-handlers/root-request-handler'
 
 const baseSettings = {
@@ -125,6 +126,16 @@ describe('rootRequestHandler', () => {
       expect(doc.terms_of_service).to.equal('https://relay.example.com/terms')
     })
 
+    it('does not include optional NIP-11 fields when not configured', () => {
+      rootRequestHandler(req, res, next)
+
+      const doc = res.send.firstCall.args[0]
+      expect(doc).to.not.have.property('banner')
+      expect(doc).to.not.have.property('icon')
+      expect(doc).to.not.have.property('self')
+      expect(doc).to.not.have.property('terms_of_service')
+    })
+
     it('includes NIP-11 limitation created_at and default_limit fields', () => {
       createSettingsStub.returns({
         ...baseSettings,
@@ -145,7 +156,7 @@ describe('rootRequestHandler', () => {
       const doc = res.send.firstCall.args[0]
       expect(doc.limitation.created_at_lower_limit).to.equal(86400)
       expect(doc.limitation.created_at_upper_limit).to.equal(300)
-      expect(doc.limitation.default_limit).to.equal(500)
+      expect(doc.limitation.default_limit).to.equal(DEFAULT_FILTER_LIMIT)
     })
 
     it('sets limitation.restricted_writes based on active write restrictions', () => {