Add Sync26 new changes (Geohashlist)#50
Open
albertoramosmonagas wants to merge 1 commit into
Open
Conversation
CAMARA Validation — PASS0 errors, 14 warnings, 5 hints | Profile: standard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This change extends Predictive Connectivity Data with optional
GEOHASHLISTarea support, following the same model introduced in Population Density Data to keep both sister APIs aligned and consistent in their area modelling.It adds reusable
GeohashListandGeohashschemas with geohash validation, restricts theprecisionfield toPOLYGONrequests only, and clarifies that usingprecisiontogether withGEOHASHLISTreturns400 INVALID_ARGUMENT. It also introduces new422errors for valid but unsupported request values:PREDICTIVE_CONNECTIVITY_DATA.UNSUPPORTED_AREA_TYPEPREDICTIVE_CONNECTIVITY_DATA.UNSUPPORTED_SERVICE_LEVELAdditionally,
CellConnectivityData.geohashis refactored to reuse the commonGeohashschema, and the API description is updated to clarifyGEOHASHLISTbehaviour, including mixed precision levels, non-contiguous geohashes, partial out-of-coverage results usingNO_DATA, and full out-of-coverage responses usingAREA_NOT_SUPPORTED.Precision handling is clarified: values outside the schema range
1–12return400 INVALID_ARGUMENT, while values within the valid schema range but unsupported by the MNO return422 PREDICTIVE_CONNECTIVITY_DATA.UNSUPPORTED_PRECISION.Which issue(s) this PR fixes:
Fixes #38, #39
Special notes for reviewers:
This change intentionally mirrors the
GEOHASHLISTmodelling introduced in Population Density Data (camaraproject/PopulationDensityData#110) to preserve consistency between both APIs.Changelog input
Additional documentation
This section can be blank.