Determine default targets from CMAKE_RN_TARGETS and FERRIC_TARGETS environment variable (#191)

* Use CMAKE_RN_TARGETS as default targets

* Pass CMAKE_RN_TARGETS when bootstrapping on CI

* Add changeset

* Use FERRIC_TARGETS as default targets for Ferric

* Pass FERRIC_TARGETS when bootstrapping on CI

Author: kraenhansen

.changeset/loud-dodos-kneel.md

@@ -0,0 +1,5 @@
+---
+"cmake-rn": minor
+---
+
+Derive default targets from the CMAKE_RN_TARGETS environment variable

.changeset/loud-paths-eat.md

@@ -0,0 +1,5 @@
+---
+"ferric-cli": minor
+---
+
+Derive default targets from the FERRIC_TARGETS environment variable

.github/workflows/check.yml

@@ -75,6 +75,9 @@ jobs:
       - run: rustup target add x86_64-linux-android aarch64-linux-android armv7-linux-androideabi i686-linux-android aarch64-apple-ios-sim
       - run: npm ci
       - run: npm run bootstrap
+        env:
+          CMAKE_RN_TARGETS: arm64-apple-ios-sim
+          FERRIC_TARGETS: aarch64-apple-ios-sim
       - run: npm run pod-install
         working-directory: apps/test-app
       - name: Run tests (iOS)
@@ -103,6 +106,9 @@ jobs:
       - run: rustup target add x86_64-linux-android aarch64-linux-android armv7-linux-androideabi i686-linux-android aarch64-apple-ios-sim
       - run: npm ci
       - run: npm run bootstrap
+        env:
+          CMAKE_RN_TARGETS: i686-linux-android
+          FERRIC_TARGETS: i686-linux-android
       - name: Clone patched Hermes version
         shell: bash
         run: |

packages/cmake-rn/src/cli.ts

@@ -41,10 +41,23 @@ const configurationOption = new Option("--configuration <configuration>")
 // TODO: Derive default targets
 // This is especially important when driving the build from within a React Native app package.
 
-const targetOption = new Option(
-  "--target <target...>",
-  "Targets to build for"
-).choices(allTargets);
+const { CMAKE_RN_TARGETS } = process.env;
+
+const defaultTargets = CMAKE_RN_TARGETS ? CMAKE_RN_TARGETS.split(",") : [];
+
+for (const target of defaultTargets) {
+  assert(
+    (allTargets as string[]).includes(target),
+    `Unexpected target in CMAKE_RN_TARGETS: ${target}`
+  );
+}
+
+const targetOption = new Option("--target <target...>", "Targets to build for")
+  .choices(allTargets)
+  .default(
+    defaultTargets,
+    "CMAKE_RN_TARGETS environment variable split by ','"
+  );
 
 const buildPathOption = new Option(
   "--build <path>",
@@ -148,16 +161,19 @@ program = program.action(
       });
 
       // Configure every triplet project
+      const targetsSummary = chalk.dim(
+        `(${getTargetsSummary(targetContexts)})`
+      );
       await oraPromise(
         Promise.all(
           targetContexts.map(({ platform, ...context }) =>
             configureProject(platform, context, baseOptions)
           )
         ),
         {
-          text: "Configuring projects",
+          text: `Configuring projects ${targetsSummary}`,
           isSilent: baseOptions.verbose,
-          successText: "Configured projects",
+          successText: `Configured projects ${targetsSummary}`,
           failText: ({ message }) => `Failed to configure projects: ${message}`,
         }
       );
@@ -208,6 +224,23 @@ program = program.action(
   }
 );
 
+function getTargetsSummary(
+  targetContexts: { target: string; platform: Platform }[]
+) {
+  const targetsPerPlatform: Record<string, string[]> = {};
+  for (const { target, platform } of targetContexts) {
+    if (!targetsPerPlatform[platform.id]) {
+      targetsPerPlatform[platform.id] = [];
+    }
+    targetsPerPlatform[platform.id].push(target);
+  }
+  return Object.entries(targetsPerPlatform)
+    .map(([platformId, targets]) => {
+      return `${platformId}: ${targets.join(", ")}`;
+    })
+    .join(" / ");
+}
+
 function getBuildPath({ build, source }: BaseOpts) {
   // TODO: Add configuration (debug vs release)
   return path.resolve(process.cwd(), build || path.join(source, "build"));

packages/ferric/src/build.ts

@@ -18,7 +18,7 @@ import {
   prettyPath,
 } from "react-native-node-api";
 
-import { UsageError } from "./errors.js";
+import { UsageError, assertFixable } from "./errors.js";
 import { ensureCargo, build } from "./cargo.js";
 import {
   ALL_TARGETS,
@@ -62,9 +62,26 @@ const ANDROID_TRIPLET_PER_TARGET: Record<AndroidTargetName, AndroidTriplet> = {
 const DEFAULT_NDK_VERSION = "27.1.12297006";
 const ANDROID_API_LEVEL = 24;
 
+const { FERRIC_TARGETS } = process.env;
+
+function getDefaultTargets() {
+  const result = FERRIC_TARGETS ? FERRIC_TARGETS.split(",") : [];
+  for (const target of result) {
+    assertFixable(
+      (ALL_TARGETS as readonly string[]).includes(target),
+      `Unexpected target in FERRIC_TARGETS: ${target}`,
+      {
+        instructions:
+          "Pass only valid targets via FERRIC_TARGETS (or remove them)",
+      }
+    );
+  }
+  return result as (typeof ALL_TARGETS)[number][];
+}
+
 const targetOption = new Option("--target <target...>", "Target triple")
   .choices(ALL_TARGETS)
-  .default([]);
+  .default(getDefaultTargets());
 const appleTarget = new Option("--apple", "Use all Apple targets");
 const androidTarget = new Option("--android", "Use all Android targets");
 const ndkVersionOption = new Option(