Priority: P3 (Medium - Plan to Fix)
Problem
In src/Actions/Integrations/ImportOhDearFeed.php:38, the comparison $site['status'] === 'up' uses a raw magic string.
The ExternalProviderEnum already has a status() method that maps external strings to IncidentStatusEnum, but there is no equivalent for component status mapping.
Suggested Fix
Add a componentStatus() method to ExternalProviderEnum (or a dedicated mapper) to centralize the 'up' / 'down' to ComponentStatusEnum mapping.
Priority: P3 (Medium - Plan to Fix)
Problem
In
src/Actions/Integrations/ImportOhDearFeed.php:38, the comparison$site['status'] === 'up'uses a raw magic string.The
ExternalProviderEnumalready has astatus()method that maps external strings toIncidentStatusEnum, but there is no equivalent for component status mapping.Suggested Fix
Add a
componentStatus()method toExternalProviderEnum(or a dedicated mapper) to centralize the'up'/'down'toComponentStatusEnummapping.