panic when trying to use list<string>

[cataggar]

Thanks for fixing #166 in #168. I was able to get the JavaScript comopnent to use a Rust component and have it used in a Rust component. When I try to use get-arguments: func() -> list<string>; from the JavaScript component it panics, but works fine with hello: func() -> string;.

interface types {
    resource system {
        constructor();
        get-arguments: func() -> list<string>;
        hello: func() -> string;
    }
}

~/ms/StarlingMonkey15> bun run build.ts
$ wkg wit fetch

$ cargo component build
  Generating bindings for typescript-system (src/bindings.rs)
   Compiling typescript-system v0.1.0 (/Users/cataggar/ms/StarlingMonkey15/typescript-system)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s
    Creating component target/wasm32-wasip1/debug/typescript_system.wasm

$ wkg wit fetch

$ bunx jco types wit -o .

  Generated Type Files:

 - ./interfaces/ts-typescript-system-types.d.ts  0.16 KiB
 - ./interfaces/ts-typescript-typescript.d.ts    0.25 KiB
 - ./interfaces/wasi-io-poll.d.ts                1.36 KiB
 - ./wit.d.ts                                    0.28 KiB


$ bun run bundle.ts

$ bunx jco componentize world.js --wit wit -o ts-typescript.wasm -d all
OK Successfully written ts-typescript.wasm.

$ wkg wit fetch

$ cargo component build
  Generating bindings for test-rs (src/bindings.rs)
   Compiling test-rs v0.1.0 (/Users/cataggar/ms/StarlingMonkey15/test-rs)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s
    Creating component target/wasm32-wasip1/debug/test-rs.wasm

$ wac plug target/wasm32-wasip1/debug/test-rs.wasm -o target/test.wasm --plug ../typescript/ts-typescript.wasm

$ wac plug target/test.wasm -o target/test2.wasm --plug ../typescript-system/target/wasm32-wasip1/debug/typescript_system.wasm

$ WASMTIME_BACKTRACE_DETAILS=1 wasmtime run target/test2.wasm a b c
Error: failed to run main module `target/test2.wasm`

Caused by:
    0: failed to invoke `run` function
    1: error while executing at wasm backtrace:
           0: 0x214216 - <unknown>!<wasm function 140>
           1: 0x21421f - <unknown>!<wasm function 141>
           2: 0x418622 - <unknown>!<wasm function 4967>
           3: 0x9911cb - <unknown>!ts:typescript/typescript@0.1.0#[method]program.concat-arguments
           4:  0x167 - <unknown>!<wasm function 7>
           5: 0xe67938 - wit-component:shim!indirect-ts:typescript/typescript@0.1.0-[method]program.concat-arguments
           6: 0xc22350 - test_rs::bindings::ts::typescript::typescript::Program::concat_arguments::hb0488eb1671ca607
                           at /Users/cataggar/ms/StarlingMonkey15/test-rs/src/bindings.rs:89:25
           7: 0xc23134 - test_rs::main::h692cc828dd231e3d
                           at /Users/cataggar/ms/StarlingMonkey15/test-rs/src/main.rs:8:20
           8: 0xc22dca - core::ops::function::FnOnce::call_once::hbdd50cb57cdd17d7
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ops/function.rs:250:5
           9: 0xc22979 - std::sys::backtrace::__rust_begin_short_backtrace::h7c8f96b7bf4677a5
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/sys/backtrace.rs:152:18
          10: 0xc21e3d - std::rt::lang_start::{{closure}}::h2dd43ab9810fe77f
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/rt.rs:162:18
          11: 0xc35d2c - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::hda5cc35229b3e2d7
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ops/function.rs:284:13              - std::panicking::try::do_call::h0757ac3fec725a99
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:557:40              - std::panicking::try::h812b834d48089f5c
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:521:19              - std::panic::catch_unwind::hbe21da14a7442526
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panic.rs:350:14              - std::rt::lang_start_internal::{{closure}}::h5f6564c4db031e37
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/rt.rs:141:48              - std::panicking::try::do_call::h09de3a5111bf0861
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:557:40              - std::panicking::try::h1d0b07860d5981d0
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:521:19              - std::panic::catch_unwind::haad2596de262ec59
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panic.rs:350:14              - std::rt::lang_start_internal::hdc680a054eeeacf1
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/rt.rs:141:20
          12: 0xc21dd9 - std::rt::lang_start::hbf668ad2f05c9ebb
                           at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/rt.rs:161:17
          13: 0xc23282 - test_rs-6fa4481e8149828b.wasm!__main_void
          14: 0xc21b18 - test_rs-6fa4481e8149828b.wasm!_start
          15: 0xe64e1f - wit-component:adapter:wasi_snapshot_preview1!wasi:cli/run@0.2.0#run
    2: wasm trap: wasm `unreachable` instruction executed
error: script "run" exited with code 134

In 'test-rs' script 'run' failed with exit code 134

[cataggar]

Steps to reproduce:

git clone git@github.com:cataggar/StarlingMonkey15.git --no-checkout
cd StarlingMonkey15
git checkout ComponentizeJS171
bun install
bun run build.ts

This is using local copies of jco and ComponentizeJS. Freshly built. Assumes they are sibling folders.
"@bytecodealliance/jco": "file:../../jco"
"@bytecodealliance/componentize-js": "file:../ComponentizeJS",

[cataggar]

Returning a record works.
https://github.com/cataggar/StarlingMonkey15/compare/ComponentizeJS171...ComponentizeJS171b?expand=1

[guybedford]

You need to change this line:

return this.system.getArguments().concat("__");

into:

return this.system.getArguments().concat("__").join('');

so that it returns a string.

Adding stdio to the features when using componentize (which is the default if you don't pass -d clocks -d random -d http) provides the error:

expected a string
Stack:
  utf8Encode@world.bindings.js:99:36
  export_typescript_0_1_0$program$method$concatArguments@world.bindings.js:213:24

Redirecting call to abort() to mozalloc_abort

[cataggar]

It is great to be able to see the errors! I appreciate the help. I didn't realize that disabling stdio had that impact, but makes sense. Confirmed that was the fix.

• fix was to not remove 'stdio' from features cataggar/StarlingMonkey15#3

~/ms/StarlingMonkey15/typescript> bunx jco componentize --help
Usage: jco componentize <js-source> --wit wit-world.wit -o <component-path>

Create a component from a JavaScript module

Arguments:
  js-source                     JS source file to build

Options:
  -w, --wit <path>              WIT path to build with
  -n, --world-name <name>       WIT world to build
  --aot                         Enable Weval AOT compilation of JS
  --weval-bin <path>            Specify a custom weval binary to use
  -d, --disable <feature...>    disable WASI features (choices: "clocks", "http", "random", "stdio", "all")
  --preview2-adapter <adapter>  provide a custom preview2 adapter path
  -o, --out <out>               output component file
  -h, --help                    display help for command