refactor(splicer): add explicit error for invalid WIT source

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>

Author: vados-cosmonic

crates/spidermonkey-embedding-splicer/src/lib.rs

@@ -70,13 +70,17 @@ fn map_core_fn(cfn: &bindgen::CoreFn) -> CoreFn {
     }
 }
 
-fn parse_wit(path: &Path) -> Result<(Resolve, PackageId)> {
+fn parse_wit(path: impl AsRef<Path>) -> Result<(Resolve, PackageId)> {
     let mut resolve = Resolve::default();
+    let path = path.as_ref();
     let id = if path.is_dir() {
-        resolve.push_dir(&path)?.0
+        resolve
+            .push_dir(&path)
+            .with_context(|| format!("resolving WIT in {}", path.display()))?
+            .0
     } else {
         let contents =
-            std::fs::read(&path).with_context(|| format!("failed to read file {path:?}"))?;
+            std::fs::read(&path).with_context(|| format!("reading file {}", path.display()))?;
         let text = match std::str::from_utf8(&contents) {
             Ok(s) => s,
             Err(_) => bail!("input file is not valid utf-8"),

crates/spidermonkey-embedding-splicer/src/splice.rs

@@ -33,15 +33,19 @@ pub fn splice_bindings(
     wit_source: Option<String>,
     debug: bool,
 ) -> Result<SpliceResult, String> {
-    let (mut resolve, id) = if let Some(wit_source) = wit_source {
-        let mut resolve = Resolve::default();
-        let path = PathBuf::from("component.wit");
-        let id = resolve
-            .push_str(&path, &wit_source)
-            .map_err(|e| e.to_string())?;
-        (resolve, id)
-    } else {
-        parse_wit(&PathBuf::from(wit_path.unwrap())).map_err(|e| format!("{:?}", e))?
+    let (mut resolve, id) = match (wit_source, wit_path) {
+        (Some(wit_source), _) => {
+            let mut resolve = Resolve::default();
+            let path = PathBuf::from("component.wit");
+            let id = resolve
+                .push_str(&path, &wit_source)
+                .map_err(|e| e.to_string())?;
+            (resolve, id)
+        }
+        (_, Some(wit_path)) => parse_wit(&wit_path).map_err(|e| format!("{:?}", e))?,
+        (None, None) => {
+            return Err("neither wit source nor path have been specified".into());
+        }
     };
 
     let world = resolve