Carthage support

[bre7]

Dependency wise: SDWebImage does support Carthage already but DACircularProgress doesn't :( (there's an open PR about it though: 60)

Use the PR in a custom fork ? Or accept #15 and exclude DACircularProgress ?

[DreamingInBinary]

Hmmm that's a good one. I think we proposed #15 because we thought there was an issue with DACircularProgress but it was actually an issue with the content headers for the images we were requesting. @humberaquino do you know of a good way around this? I haven't used Carthage too much 😄

cc @ay8s

[humberaquino]

Thanks @bre7 !! And good one @DreamingInBinary !

PR #15 was a quick solution for an issue we had with DACircularProgress and our image proxy. We ended up fixing the issue with the proxy and after that the download progress worked again as expected so I think that PR should be closed without merging.

To support carthage and still use DACircularProgress we might want to fork DACircularProgress, merge the carthage support there and use it as our dependency. After that it should be easy to add carthage support for the image viewer.

Would love to know your opinion and @ay8s

[bre7]

Yeah, adding Carthage support in a custom fork would be the easiest option (PR already there danielamitay/DACircularProgress#60)

Closing for now.