Merge branch '26-fix-ecs-tagging-permissions' into 'develop'

briancaffey · briancaffey · commit 9eddff8f0b3f · 2020-05-15T02:28:37.000Z
Resolve "Tagging resources with CDK gives: Did not have IAM permissions to process tags on AWS::ECS::Service resource." Closes #26 See merge request verbose-equals-true/django-postgres-vue-gitlab-ecs!67
diff --git a/awscdk/app.py b/awscdk/app.py
@@ -27,6 +27,10 @@
     env={"region": "us-east-1"},
 )
 
+# in order to be able to tag ECS resources, you need to go to
+# the ECS Console > Account Settings > Amazon ECS ARN and resource ID settings
+# and enable at least Service and Task. Optionally enable
+# CloudWatch Container Insights
 stack.node.apply_aspect(core.Tag("StackName", full_app_name))
 
 app.synth()
diff --git a/awscdk/awscdk/rds.py b/awscdk/awscdk/rds.py
@@ -68,7 +68,7 @@ def __init__(
             "engine_mode": "serverless",
             "engine": "aurora-postgresql",
             "engine_version": "10.7",
-            "port": 5432,
+            # "port": 5432,
             "enable_http_endpoint": True,
             "master_username": self.db_secret.secret_value_from_json(
                 "username"

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,10 @@`
`27`	`27`	`env={"region": "us-east-1"},`
`28`	`28`	`)`
`29`	`29`
	`30`	`+# in order to be able to tag ECS resources, you need to go to`
	`31`	`+# the ECS Console > Account Settings > Amazon ECS ARN and resource ID settings`
	`32`	`+# and enable at least Service and Task. Optionally enable`
	`33`	`+# CloudWatch Container Insights`
`30`	`34`	`stack.node.apply_aspect(core.Tag("StackName", full_app_name))`
`31`	`35`
`32`	`36`	`app.synth()`