requests' session is created every time

[yabirgb]

Instead of reusing a requests' session the code creates a new one each time

braintree_python/braintree/util/http.py

Line 116 in 7d9bf8a

with requests.Session() as session:

this means that DNS resolution is performed for every request for example in addition to other steps that take place during the connection.
We have noticed this because every now and then we see resolution errors when calling the Braintree API using the sdk.

Task

• Use correctly request's session in the code

[nalshapub]

We'll take a look at it. Thanks for letting us know/.

[yabirgb]

Hello @nalshapub, went ahead and made a PR

[nalshapub]

Hi, this is taken care of in the latest release.

[teewuane]

This made the object that is returned from a call thread-local, so now it can not be pickled and cached/stored in redis :(
I know it will speed up performance and won't have to make so many handshakes, but now it can't really be cached, which was my way of optimizing and reducing calls.