Adds tests (#31)

So many tests

Author: withinboredom

.github/workflows/Test.yaml

@@ -7,8 +7,8 @@ on:
     branches:
       - v2
 jobs:
-  unit-tests:
-    name: Unit Tests
+  unit-tests-php:
+    name: Unit Tests - PHP
     runs-on: self-hosted
     steps:
       - uses: actions/checkout@v4

.github/workflows/build-cli.yaml

@@ -48,6 +48,8 @@ jobs:
           path: bin/dphp
   build-docker:
     runs-on: self-hosted
+    outputs:
+      image: ${{ steps.meta.outputs.tags }}
     steps:
       - uses: actions/checkout@v4
       - name: Login to Docker Hub
@@ -102,6 +104,19 @@ jobs:
           cache-from: type=gha,scope=image
           cache-to: type=gha,mode=max,scope=image
           platforms: linux/amd64,linux/arm64
+      - name: Build Test Image
+        uses: docker/build-push-action@v5
+        with:
+          context: ./
+          file: Dockerfile
+          target: test
+          push: true
+          pull: true
+          tags: ghcr.io/${{ github.repository_owner }}/durable-php/runtime-tests:${{ github.sha }}
+          labels: ${{ steps.meta.outputs.labels }}
+          builder: ${{ steps.buildx.outputs.name }}
+          cache-from: type=gha,scope=image
+          platforms: linux/amd64
   build-osx:
     strategy:
       fail-fast: true
@@ -143,3 +158,40 @@ jobs:
         with:
           name: dphp-${{ runner.os }}-${{ matrix.platform }}
           path: cli/dist/dphp
+  performance-test:
+    name: Performance Test
+    needs:
+      - build-docker
+      - build-linux
+    runs-on: self-hosted
+    container: ghcr.io/${{ github.repository_owner }}/durable-php/runtime-tests:${{ github.sha }}
+    services:
+      dphp:
+        image: ghcr.io/${{ github.repository_owner }}/durable-php/runtime-tests:${{ github.sha }}
+        ports:
+          - 8080:8080
+        volumes:
+          - ${{ github.workspace }}:/app
+    env:
+      DPHP_HOST: http://dphp:8080
+    steps:
+      - uses: actions/checkout@v4
+      - run: |
+          dphp composer install
+      - run: |
+          echo "Running perf test"
+          dphp exec tests/PerformanceTests/PerformanceClient.php
+          echo "Running fan out/in test"
+          dphp exec tests/PerformanceTests/FanOutFanInClient.php
+          echo "Running seq test"
+          dphp exec tests/PerformanceTests/SequenceClient.php
+      - uses: peter-evans/find-comment@v3
+        id: fc
+        with:
+          issue-number: ${{ github.event.pull_request.number }}
+          body-includes: Performance Metrics
+      - uses: peter-evans/create-or-update-comment@v4
+        with:
+          comment-id: ${{ steps.fc.outputs.comment-id }}
+          issue-number: ${{ github.event.pull_request.number }}
+          body-path: report.md

.github/workflows/cleanup.yaml

@@ -0,0 +1,24 @@
+name: Package Cleanup
+on:
+  schedule:
+    - cron: "0 0 * * *"
+jobs:
+  dangling-images:
+    name: Clean up dangling images
+    runs-on: self-hosted
+    steps:
+      - uses: actions/delete-package-versions@v5
+        with:
+          package-name: runtime
+          package-type: container
+          min-versions-to-keep: 5
+          delete-only-untagged-versions: 'true'
+  old-test-images:
+    name: Clean up test images
+    runs-on: self-hosted
+    steps:
+      - uses: actions/delete-package-versions@v5
+        with:
+          package-name: 'runtime-tests'
+          package-type: 'container'
+          min-versions-to-keep: 10

Dockerfile

@@ -103,10 +103,16 @@ ARG VERSION=dev
 ENV CGO_LDFLAGS="-lssl -lcrypto -lreadline -largon2 -lcurl -lonig -lz $PHP_LDFLAGS" CGO_CFLAGS="-DFRANKENPHP_VERSION=$VERSION $PHP_CFLAGS" CGO_CPPFLAGS=$PHP_CPPFLAGS
 ENV GOBIN=/usr/local/bin
 RUN go get durable_php
+#RUN go test ./...
+
 RUN go install -ldflags "-w -s -X 'main.version=$VERSION'"
 
 FROM common AS durable-php
 COPY --from=builder /usr/local/bin/durable_php /usr/local/bin/dphp
 ENTRYPOINT ["dphp"]
 
 WORKDIR /app
+
+FROM durable-php AS test
+COPY . .
+CMD ["--bootstrap=tests/PerformanceTests/bootstrap.php","--port=8080"]

bin/composer.phar

@@ -210,7 +210,7 @@ func (r *Resource) isUserPermitted(perms CreatePermissions, ctx context.Context)
 }
 
 func (r *Resource) isUserExplicitlyPermitted(perms CreatePermissions, ctx context.Context) bool {
-	if user := ctx.Value(appcontext.CurrentUserKey).(*User); user != nil {
+	if user, ok := ctx.Value(appcontext.CurrentUserKey).(*User); ok {
 		if slices.Contains(perms.Users, user.UserId) {
 			return true
 		}

cli/auth/resource.go

@@ -20,9 +20,6 @@ func CreateEntityIndex(ctx context.Context, client *typesense.Client, config *co
 			{
 				Name: "name", Type: "string", Facet: pointer.True(),
 			},
-			{
-				Name: "id", Type: "string",
-			},
 			{
 				Name: ".*", Type: "auto",
 			},
@@ -54,9 +51,6 @@ func CreateOrchestrationIndex(ctx context.Context, client *typesense.Client, con
 			{
 				Name: "instance_id", Type: "string", Facet: pointer.True(),
 			},
-			{
-				Name: "id", Type: "string",
-			},
 			{
 				Name: "created_at", Type: "string",
 			},
@@ -72,6 +66,9 @@ func CreateOrchestrationIndex(ctx context.Context, client *typesense.Client, con
 		},
 		Name: config.Stream + "_orchestrations",
 	})
+	if err != nil {
+		return err
+	}
 
 	return nil
 }

cli/lib/index.go

@@ -76,7 +76,7 @@ func IndexerListen(ctx context.Context, config *config.Config, kind glue.IdKind,
 						BatchSize: pointer.Int(40),
 					})
 					if err != nil {
-						logger.Warn("Failure uploading batch to index", zap.Error(err))
+						logger.Warn("Failure uploading entity batch to index", zap.Error(err))
 						continue
 					}
 				}
@@ -200,7 +200,7 @@ func IndexerListen(ctx context.Context, config *config.Config, kind glue.IdKind,
 						BatchSize: pointer.Int(40),
 					})
 					if err != nil {
-						logger.Warn("Failure uploading batch to index", zap.Error(err))
+						logger.Warn("Failure uploading orchestration batch to index", zap.Error(err))
 						continue
 					}
 				}

cli/lib/indexer.go

@@ -26,11 +26,11 @@
   "license": "MIT",
   "name": "bottledcode/durable-php",
   "require": {
-    "adhocore/cli": "^1.6.2",
+    "adhocore/cli": "^1.7.1",
     "amphp/file": "^3.0.2",
     "amphp/http-client": "^v5.0.1",
     "amphp/log": "^v2.0.0",
-    "amphp/parallel": "^2.2.8",
+    "amphp/parallel": "^2.2.9",
     "crell/serde": "^1.1.0",
     "nesbot/carbon": ">2.0",
     "php": ">=8.3",
@@ -40,9 +40,9 @@
     "webonyx/graphql-php": "^15.11.1"
   },
   "require-dev": {
-    "laravel/pint": "^1.14.0",
+    "laravel/pint": "^1.15.1",
     "mockery/mockery": "^1.6.11",
-    "pestphp/pest": "^2.34.5"
+    "pestphp/pest": "^2.34.7"
   },
   "scripts": {
     "test": "pest"

composer.json

@@ -29,8 +29,10 @@
 use Bottledcode\DurablePhp\State\EntityState;
 use Bottledcode\DurablePhp\State\OrchestrationInstance;
 use Bottledcode\DurablePhp\State\Status;
+use Closure;
 use DateTimeImmutable;
 use Generator;
+use Override;
 
 final readonly class DurableClient implements DurableClientInterface
 {
@@ -123,14 +125,20 @@ public function getEntitySnapshot(EntityId $entityId, string $type): ?EntityStat
         return $this->entityClient->getEntitySnapshot($entityId, $type);
     }
 
-    public function signal(EntityId|string $entityId, \Closure $signal): void
+    public function signal(EntityId|string $entityId, Closure $signal): void
     {
         $this->entityClient->signal($entityId, $signal);
     }
 
-    #[\Override] public function withAuth(string $token): void
+    #[Override]
+    public function withAuth(string $token): void
     {
         $this->orchestrationClient->withAuth($token);
         $this->entityClient->withAuth($token);
     }
+
+    public function deleteEntity(EntityId $entityId): void
+    {
+        $this->entityClient->deleteEntity($entityId);
+    }
 }