-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
code qualityIssues that involve improving code quality but don't necessarily contribute to features/bug fixesIssues that involve improving code quality but don't necessarily contribute to features/bug fixes
Milestone
Description
There are a few problems with this:
-
undoableActionin the redux store is mutated directly. nothing in the redux store should ever be mutated. - it doesn't handle the case when there is no "topmost action" to undo/redo very well. See the call sites for
ReadonlyCMBEditor.getTopmostActionfor examples.
Metadata
Metadata
Assignees
Labels
code qualityIssues that involve improving code quality but don't necessarily contribute to features/bug fixesIssues that involve improving code quality but don't necessarily contribute to features/bug fixes