Skip to content

Commit 3b3d208

Browse files
committed
Revert "disable unity"
This reverts commit dd8645d.
1 parent dd8645d commit 3b3d208

File tree

2 files changed

+3
-19
lines changed

2 files changed

+3
-19
lines changed

ci/scripts/jni_macos_build.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ export ARROW_ORC
7272
: "${ARROW_PARQUET:=ON}"
7373
: "${ARROW_S3:=ON}"
7474
: "${CMAKE_BUILD_TYPE:=Release}"
75-
# Disable Unity build due to compilation issues with Gandiva
76-
: "${CMAKE_UNITY_BUILD:=OFF}"
75+
: "${CMAKE_UNITY_BUILD:=ON}"
7776

7877
export ARROW_TEST_DATA="${arrow_dir}/testing/data"
7978
export PARQUET_TEST_DATA="${arrow_dir}/cpp/submodules/parquet-testing/data"

ci/scripts/jni_manylinux_build.sh

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -71,20 +71,6 @@ fi
7171
github_actions_group_begin "Building Arrow C++ libraries"
7272
devtoolset_version="$(rpm -qa "devtoolset-*-gcc" --queryformat '%{VERSION}' | grep -o "^[0-9]*")"
7373
devtoolset_include_cpp="/opt/rh/devtoolset-${devtoolset_version}/root/usr/include/c++/${devtoolset_version}"
74-
75-
# Detect architecture for devtoolset include path
76-
case "$(uname -m)" in
77-
x86_64)
78-
devtoolset_arch="x86_64-redhat-linux"
79-
;;
80-
aarch64)
81-
devtoolset_arch="aarch64-redhat-linux"
82-
;;
83-
*)
84-
devtoolset_arch="$(uname -m)-redhat-linux"
85-
;;
86-
esac
87-
8874
: "${ARROW_ACERO:=ON}"
8975
export ARROW_ACERO
9076
: "${ARROW_BUILD_TESTS:=OFF}"
@@ -102,12 +88,11 @@ export ARROW_ORC
10288
: "${ARROW_PARQUET:=ON}"
10389
: "${ARROW_S3:=ON}"
10490
: "${CMAKE_BUILD_TYPE:=release}"
105-
# Disable Unity build due to compilation issues with Gandiva
106-
: "${CMAKE_UNITY_BUILD:=OFF}"
91+
: "${CMAKE_UNITY_BUILD:=ON}"
10792
: "${VCPKG_ROOT:=/opt/vcpkg}"
10893
: "${VCPKG_FEATURE_FLAGS:=-manifests}"
10994
: "${VCPKG_TARGET_TRIPLET:=${VCPKG_DEFAULT_TRIPLET:-x64-linux-static-${CMAKE_BUILD_TYPE}}}"
110-
: "${GANDIVA_CXX_FLAGS:=-isystem;${devtoolset_include_cpp};-isystem;${devtoolset_include_cpp}/${devtoolset_arch};-lpthread}"
95+
: "${GANDIVA_CXX_FLAGS:=-isystem;${devtoolset_include_cpp};-isystem;${devtoolset_include_cpp}/x86_64-redhat-linux;-lpthread}"
11196

11297
export ARROW_TEST_DATA="${arrow_dir}/testing/data"
11398
export PARQUET_TEST_DATA="${arrow_dir}/cpp/submodules/parquet-testing/data"

0 commit comments

Comments
 (0)