Skip to content

Commit dc59763

Browse files
committed
chore: Address Rubocop offenses
1 parent bc15c44 commit dc59763

15 files changed

Lines changed: 60 additions & 61 deletions

lib/tiny_admin/context.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ module TinyAdmin
77
:repository,
88
:request,
99
:router,
10-
:slug,
11-
keyword_init: true
10+
:slug
1211
)
1312
end

lib/tiny_admin/router.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def store
4848

4949
def render_page(page)
5050
if page.respond_to?(:messages=)
51-
page.messages = {notices: flash["notices"], warnings: flash["warnings"], errors: flash["errors"]}
51+
page.messages = { notices: flash["notices"], warnings: flash["warnings"], errors: flash["errors"] }
5252
end
5353
render(inline: page.call)
5454
end

lib/tiny_admin/store.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ def prepare_sections(sections, logout:)
2323

2424
slug = section[:slug].to_s
2525
item = case section[:type]&.to_sym
26-
when :content then add_content_section(slug, section)
27-
when :page then add_page_section(slug, section)
28-
when :resource then add_resource_section(slug, section)
29-
when :url then add_url_section(slug, section)
30-
end
26+
when :content then add_content_section(slug, section)
27+
when :page then add_page_section(slug, section)
28+
when :resource then add_resource_section(slug, section)
29+
when :url then add_url_section(slug, section)
30+
end
3131
list << item if item
3232
end
3333
navbar << logout if logout
@@ -36,12 +36,12 @@ def prepare_sections(sections, logout:)
3636
private
3737

3838
def add_content_section(slug, section)
39-
pages[slug] = {class: settings.content_page, content: section[:content], widgets: section[:widgets]}
39+
pages[slug] = { class: settings.content_page, content: section[:content], widgets: section[:widgets] }
4040
TinyAdmin::Section.new(name: section[:name], slug: slug)
4141
end
4242

4343
def add_page_section(slug, section)
44-
pages[slug] = {class: to_class(section[:page])}
44+
pages[slug] = { class: to_class(section[:page]) }
4545
TinyAdmin::Section.new(name: section[:name], slug: slug)
4646
end
4747

lib/tiny_admin/utils.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def prepare_page(page_class, slug: nil, attributes: nil, options: nil, params: n
3030
)
3131
attrs = attributes || {}
3232
attrs[:params] = params if params
33-
attrs[:widgets] = attrs[:widgets].map { to_class(it) } if attrs[:widgets]
33+
attrs[:widgets] = attrs[:widgets].map { to_class(_1) } if attrs[:widgets]
3434
page.update_attributes(attrs) unless attrs.empty?
3535
yield(page) if block_given?
3636
page.setup if page.respond_to?(:setup)

lib/tiny_admin/views/actions/index.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ module Views
55
module Actions
66
class Index < DefaultLayout
77
attr_accessor :actions,
8-
:fields,
9-
:filters,
10-
:links,
11-
:pagination_component,
12-
:prepare_record,
13-
:records,
14-
:slug
8+
:fields,
9+
:filters,
10+
:links,
11+
:pagination_component,
12+
:prepare_record,
13+
:records,
14+
:slug
1515

1616
def view_template
1717
super do

lib/tiny_admin/views/actions/show.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ module Views
55
module Actions
66
class Show < DefaultLayout
77
attr_accessor :actions,
8-
:fields,
9-
:prepare_record,
10-
:record,
11-
:reference,
12-
:slug
8+
:fields,
9+
:prepare_record,
10+
:record,
11+
:reference,
12+
:slug
1313

1414
def view_template
1515
super do

lib/tiny_admin/views/default_layout.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ module Views
55
class DefaultLayout < BasicLayout
66
attr_accessor :flash_component, :head_component, :messages, :navbar_component, :options, :title
77

8-
def view_template(&block)
8+
def view_template
99
extra_styles = TinyAdmin.settings.extra_styles
1010
flash_component&.messages = messages
1111
head_component&.update_attributes(page_title: title, style_links: style_links, extra_styles: extra_styles)
@@ -31,7 +31,7 @@ def view_template(&block)
3131
private
3232

3333
def body_class
34-
"module-#{self.class.to_s.split("::").last.downcase}"
34+
"module-#{self.class.to_s.split('::').last.downcase}"
3535
end
3636

3737
def main_content

lib/tiny_admin/views/pages/error_page.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ def view_template
1616

1717
def css_class
1818
self.class.name.split("::").last
19-
.gsub(/([A-Z])/, '_\1')
20-
.sub(/^_/, "")
21-
.downcase
19+
.gsub(/([A-Z])/, '_\1')
20+
.sub(/^_/, "")
21+
.downcase
2222
end
2323
end
2424
end

spec/lib/tiny_admin/configure_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require "dummy_rails_app"
44
require "rails_helper"
55

6-
RSpec.describe "TinyAdmin.configure" do
6+
RSpec.describe "TinyAdmin.configure" do # rubocop:disable RSpec/DescribeClass
77
let(:settings) { TinyAdmin::Settings.instance }
88

99
around do |example|

spec/lib/tiny_admin/settings_idempotent_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
require "dummy_rails_app"
44
require "rails_helper"
55

6-
RSpec.describe TinyAdmin::Settings, "#load_settings idempotency" do
7-
let(:settings) { described_class.instance }
6+
RSpec.describe "Settings idempotency" do # rubocop:disable RSpec/DescribeClass
7+
let(:settings) { TinyAdmin::Settings.instance }
88

99
around do |example|
1010
saved = settings.instance_variable_get(:@options)&.deep_dup

0 commit comments

Comments
 (0)