binhex vs binhex-plexpass (supervisor.conf vs supervisord.conf) and DBRepair.sh

[ChuckPa]

A user has presented a problem with stopping and starting the -plexpass image.

From what I can see,

    # BINHEX Plex image
    elif [ -e /etc/os-release ] &&  grep "IMAGE_ID=archlinux" /etc/os-release  1>/dev/null  && \
         [ -e /home/nobody/start.sh ] &&  grep PLEX_MEDIA /home/nobody/start.sh 1> /dev/null ; then

      PLEX_SQLITE="/usr/lib/plexmediaserver/Plex SQLite"
      AppSuppDir="/config"
      PID_FILE="$AppSuppDir/Plex Media Server/plexmediaserver.pid"
      DBDIR="$AppSuppDir/Plex Media Server/Plug-in Support/Databases"
      CACHEDIR="$AppSuppDir/Plex Media Server/Cache/PhotoTranscoder"
      LOGFILE="$DBDIR/DBRepair.log"
      LOG_TOOL="logger"

      if grep rpcinterface /etc/supervisor.conf > /dev/null; then
        HaveStartStop=1
        StartCommand="supervisorctl start plexmediaserver"
        StopCommand="supervisorctl stop plexmediaserver"
      fi

      HostType="BINHEX"
      return 0

    fi

is not valid for the latest (?) -plexpass version.
I'm seeing /etc/supervisord.conf and not /etc/supervisor.conf

Did I miss something when we put this together

Thanks,
C

[binhex]

My apologies @ChuckPa i must of made some changes and forgotten about the dependancy on your script.

I have made a PR to fix this up, i have tested it and it works for me:- ChuckPa/DBRepair#255

[ChuckPa]

Thanks for responding so quickly!

[ChuckPa]

@binhex

Should I maintain compatibility with both versions supervisor (which prompted this) and supervisord ?

Specifically

      if [ -e /etc/supervisor.conf ] && grep rpcinterface /etc/supervisor.conf > /dev/null; then
        HaveStartStop=1
        StartCommand="supervisorctl start plexmediaserver"
        StopCommand="supervisorctl stop plexmediaserver"

      elif [ -e /etc/supervisord.conf ] && grep rpcinterface /etc/supervisord.conf > /dev/null; then
        HaveStartStop=1
        StartCommand="supervisorctl start start-script"
        StopCommand="supervisorctl stop start-script"

      fi

[binhex]

no, just go with the single file check, there is no plan for me to switch it back and this should now be consistent for all images.