Not detecting diff

[ijpatricio]

Hello @mpociot

So I go to try it out, even with first example Dusk test.

$this->browse(function (Browser $browser) {
            $browser->visit('/')
                ->assertSee('Laravel')
                ->visualDiff('homepage');
        });

run it once, makes screenshot in VisualRegression/screenshots

Change welcome view, to LaravelX, run test again
screenshot changes, and test keeps green

I went further and...

Changed Laravel to Laravel {{ str_random(10) }}

and now test case

$this->browse(function (Browser $browser) {
            $browser->visit('/')
                ->assertSee('Laravel')
                ->visualDiff('homepage');

            $browser->visit('/')
                ->assertSee('Laravel')
                ->visualDiff('homepage');
        });

2 assertions green

screenshot

I was running the package from the fork, and on same commit as tagged 1.0.0

I had to lower version of laravel/dusk to install dev-dependencies, like the orchestra/test-dusk-workbench was in conflict and dusk test came red

Let me know if I missed from saying something, and if I can be of any help!

[ijpatricio]

Daaam. I think I got it.

On

laravel-visual-diff/src/VisualDiff.php

Lines 134 to 140 in fbf586f

	$process = new Process($fullCommand);
	$process->run();
	if ($process->isSuccessful()) {
	return rtrim($process->getOutput());
	}
	}

I added

else {
            abort(500, 'process of comparison not successful');
        }

and so it's from here, i guess. but weird because it shoul throw some exception here, right?

[ijpatricio]

[ijpatricio]

Sorry for the spam.

npm install -g pngjs

dis the trick, it's working as supposed!!

@mpociot would you like a PR to abort when that process does not go well??

And now I can continue with what we talked about :)

[ijpatricio]

So all this was because a missing dependency pngjs, that weirdly wasn't installed, as it is a nested dependency from pixelmatch.

Even so I think is very handy to know when the external node process doesn't go well.
Instructs us right away of that. If not, it just keeps getting green.

Submitted #4