Specify AppLabel for SyncComponent / ExtractComponent / ExtractResource#24420
Open
Zeophlite wants to merge 2 commits into
Open
Specify AppLabel for SyncComponent / ExtractComponent / ExtractResource#24420Zeophlite wants to merge 2 commits into
AppLabel for SyncComponent / ExtractComponent / ExtractResource#24420Zeophlite wants to merge 2 commits into
Conversation
Zeophlite
force-pushed
the
extract-extractb
branch
from
e299d0d to
5b5444c
Compare
Zeophlite
changed the title
AppLabel for SyncComponent / ExtractComponent / ExtractResource
Zeophlite
force-pushed
the
extract-extractb
branch
from
5b5444c to
114148f
Compare
Zeophlite
added
A-Rendering
Zeophlite
force-pushed
the
extract-extractb
branch
from
114148f to
3517862
Compare
Zeophlite
added
S-Needs-Review
kfc35
approved these changes
May 24, 2026
| After: | ||
|
|
||
| ```rust,ignore | ||
| impl SyncComponent<RenderApp> for TemporalAntiAliasing { |
Contributor
There was a problem hiding this comment.
I presume that the vision that eventually you could specifically a different label for SyncComponent
Does that mean the SyncComponentPlugin stuff (and etc for Extracting) is going to have some type of generalized variant too instead of being specific to RenderWorld as it is currently?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_extract#22852 )Solution
AppLabel, we need to specify forRenderAppwhen weimplthe trait directly (note that when we use the derive it, the macro will specify for us)Testing