Broaden RenderAsset API #24410
Open
larsraph wants to merge 10 commits into
Open
Conversation
…rAsset::unload_asset functionality
Member
|
I think this seems reasonable for the current API but it needs design considering there are some more important issues such as cleaning up the Mesh API and ErasedRenderAsset API. There have also been some attempts to improve the RenderAsset API (#23871, #22128), but they are not yet ideal and might need architectural changes, especially considering the direction of #23094. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The current RenderAsset API was built with
take_gpu_dataandrender_asset_usagesaround the fact that initially it handled removing assets from the MAIN_WORLDs Assets, however now that we have changed the API to require internally taking data it doesn't make sense to still automatically handle RenderAssetUsages.Solution
In order to solve these issues I broadened the API to
Extractedtype.RenderAssetUsagesor just simply Clone into the RenderWorld.Objective 2 & Solution 2
Also I added a custom
Extractedtype. This allows two things