add a helper function to create TilemapChunkTileData from Y-down tile data#24391
Open
hxYuki wants to merge 1 commit into
Open
add a helper function to create TilemapChunkTileData from Y-down tile data#24391hxYuki wants to merge 1 commit into
TilemapChunkTileData from Y-down tile data#24391hxYuki wants to merge 1 commit into
Conversation
kfc35
reviewed
May 24, 2026
Contributor
kfc35
left a comment
There was a problem hiding this comment.
The math looks good although I think i stumbled myself upon the variable names for a little(“upper_start” is actually “earlier” in the data and corresponds to what will be the “higher indices” part of the resulting vec). I don’t have any suggestions in this realm, beyond maybe renaming or maybe adding a comment about the names.
I think to aid with comprehension and to ensure correctness, I would like a couple tests to be written (perhaps two tests with an even chunk_size.y and an odd chunk_size.y).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
TilemapChunkTileData::from_y_down_tilesTilemapChunkTileDatato explain how the data is interpreted.