Preserve nanosecond precision for Timestamp#213
Open
ClausHolbechArista wants to merge 1 commit into
Open
Conversation
Add NanoDatetime to carry sub-microsecond precision through Timestamp conversions and JSON parsing/formatting while keeping generated field types as datetime.datetime. Generate the NanoDatetime import only for known types that need it, and add runtime/compiler coverage for the new behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NanoDatetimeto preserve sub-microsecond precision forgoogle.protobuf.TimestampNanoDatetimedatetime.datetimeNanoDatetimeimport only for known types that need itdatetime.datetimeto keep this non-breaking.NanoDatetimesubclass still satisfies typecheckers.Testing
uv run pytest tests/test_nano_datetime.py tests/test_timestamp.py -quv run pytest tests/test_known_type_imports.py -quv run ruff check ...uv run pyright ...uv run poe generateuv run poe get-local-compiled-testsChecklist