Skip to content

[ID3v2] TCON Frame #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benrr101 merged 6 commits into from
May 22, 2026
Merged

[ID3v2] TCON Frame #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2375432
:robot: Move TCON frame code to its own class.
benrr101 May 22, 2026
01751d4
:robot: Move remaining TCON tests to TCON tests file.
benrr101 May 22, 2026
8f6d97f
:robot: More tests
benrr101 May 22, 2026
84f490f
Add StringUtils.trimEnd, fix bug in StringUtils.trimStart, add tests …
benrr101 May 22, 2026
d50d910
Rework genre frame code to remove redundant trimming code.
benrr101 May 22, 2026
57a5fb7
Rename tcon frame tests to genre frame tests
benrr101 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/id3v2/frames/frame.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ export enum FrameClassType {
*/
EventTimeCodeFrame,

/**
* Indicates the frame is a genre frame.
*/
GenreFrame,

Comment thread
benrr101 marked this conversation as resolved.
/**
* Indicates the frame is a music CD identifier frame.
*/
Expand Down Expand Up @@ -94,7 +99,7 @@ export enum FrameClassType {
/**
* Indicates the frame is a user URL link frame.
*/
UserUrlLinkFrame
UserUrlLinkFrame,
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/id3v2/frames/frameFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import AttachmentFrame from "./attachmentFrame";
import CommentsFrame from "./commentsFrame";
import GenreFrame from "./genreFrame";
import MusicCdIdentifierFrame from "./musicCdIdentifierFrame";
import PlayCountFrame from "./playCountFrame";
import PopularimeterFrame from "./popularimeterFrame";
Expand Down Expand Up @@ -176,7 +177,10 @@ export class Id3v2FrameFactory {
}

let func: FrameCreator;
if (header.frameId === FrameIdentifiers.TXXX) {
if (header.frameId === FrameIdentifiers.TCON) {
// Content type frame
func = GenreFrame.fromOffsetRawData;
} else if (header.frameId === FrameIdentifiers.TXXX) {
// User text identification frame
func = UserTextInformationFrame.fromOffsetRawData;
} else if (header.frameId.isTextFrame) {
Expand Down
Loading