Add extra_exec_rustc_flags_triples to toolchain attributes#3911
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
We have: extra_rustc_flags extra_rustc_flags_triples extra_exec_rustc_flags , so rounding out the set. Hit this when passing `-Clink-self-contained=no` to the toolchain, and this is only available on x86_64 rust toolchains.
Ahajha
force-pushed
the
trotta/extra_exec_triple
branch
from
9d4514e to
75b450f
Compare
UebelAndre
approved these changes
May 22, 2026
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have:
extra_rustc_flags
extra_rustc_flags_triples
extra_exec_rustc_flags
, so rounding out the set. Hit this when passing
-Clink-self-contained=noto the toolchain, and this is only available on x86_64 rust toolchains.