nxos: add n9kv eBGP lab and wire lab_builder for NX-OS#186
Merged
Conversation
Add a two-router eBGP lab collected from a real Cisco N9Kv (NX-OS 10.3.9.M) to validate Batfish against live NX-OS device state. lab_builder changes: - Add CISCO_N9KV vendor profile (cisco_n9kv containerlab kind, cisco_nxos netmiko type, Ethernet1/N interface mapping) - Add NX-OS health checks for BGP (show ip bgp summary) and OSPF (show ip ospf neighbors); return None for ISIS - Skip platform-warning checks for NX-OS Parser fix: - NX-OS interface grammar: accept "Kbit ," (space before comma) in the MTU/BW line, matching n9kv 10.3.x output format Lab (nxos_n9kv_ebgp): - Two n9kv routers in eBGP (AS 65001/65002), advertising loopbacks - Collected from vrnetlab/cisco_n9kv:10.3.9.M on EC2 m8i.2xlarge - 10 tests pass, 3 xfailed (management VRF static route and mgmt0 bandwidth — both vrnetlab artifacts not in startup config) infra/README.md: document NX-OS in vendor profiles table, interface mapping, and show commands collected. ---- Prompt: ``` Now that we have nexus support, add a hello world lab and collect it. ``` commit-id:d05cdbb8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 83.59% 83.59%
=======================================
Files 87 87
Lines 4194 4194
=======================================
Hits 3506 3506
Misses 688 688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a two-router eBGP lab collected from a real Cisco N9Kv (NX-OS
10.3.9.M) to validate Batfish against live NX-OS device state.
lab_builder changes:
cisco_nxos netmiko type, Ethernet1/N interface mapping)
OSPF (show ip ospf neighbors); return None for ISIS
Parser fix:
the MTU/BW line, matching n9kv 10.3.x output format
Lab (nxos_n9kv_ebgp):
bandwidth — both vrnetlab artifacts not in startup config)
infra/README.md: document NX-OS in vendor profiles table, interface
mapping, and show commands collected.
Prompt:
Stack: